Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable loading of external assets through a "twiddle.json" #60

Merged
merged 6 commits into from
Jul 20, 2015

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Jul 20, 2015

@@ -73,5 +75,10 @@ module.exports = function() {
// please specify an object with the list of modules as keys
// along with the exports of each module as its value.

return app.toTree();
var bowerTree = funnel('bower_components', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make sure this gets fingerprinted + minified to a single file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to both do that and make it possible for the files to be individually overridden. Any ideas?

@joostdevries
Copy link
Member

Like where this is going but I'm pondering over doing a client-side 'build' (XHR'ing all the vendor js once and injecting a bigass js string) vs. injecting multiple script src tags.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jul 20, 2015

Perhaps I am misunderstanding, but can you even do that with external dependencies?

@joostdevries
Copy link
Member

probably not easily because of cors.. looking into it now.

@joostdevries
Copy link
Member

@Gaurav0 I'll merge this in but a deploy will be later this week (but before the Ember NYC meetup I promise ;-)). Want to try some stuff out first

joostdevries pushed a commit that referenced this pull request Jul 20, 2015
Enable loading of external assets through a "twiddle.json"
@joostdevries joostdevries merged commit ea0aecd into ember-cli:master Jul 20, 2015
@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jul 20, 2015

@joostdevries Thank you.

@joostdevries
Copy link
Member

hoped to deploy tonight but had a minor crisis to attend :-(

@stefanpenner
Copy link
Contributor

hoped to deploy tonight but had a minor crisis to attend :-(

hope all is well :)

@Gaurav0 Gaurav0 deleted the bower branch March 21, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants