-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable loading of external assets through a "twiddle.json" #60
Conversation
Gaurav0
commented
Jul 20, 2015
- Fixes issue Allow multiple ember versions #38 as well; allows you to load any version of ember or ember-data
@@ -73,5 +75,10 @@ module.exports = function() { | |||
// please specify an object with the list of modules as keys | |||
// along with the exports of each module as its value. | |||
|
|||
return app.toTree(); | |||
var bowerTree = funnel('bower_components', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make sure this gets fingerprinted + minified to a single file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to both do that and make it possible for the files to be individually overridden. Any ideas?
Like where this is going but I'm pondering over doing a client-side 'build' (XHR'ing all the vendor js once and injecting a bigass js string) vs. injecting multiple script src tags. |
Perhaps I am misunderstanding, but can you even do that with external dependencies? |
probably not easily because of cors.. looking into it now. |
@Gaurav0 I'll merge this in but a deploy will be later this week (but before the Ember NYC meetup I promise ;-)). Want to try some stuff out first |
Enable loading of external assets through a "twiddle.json"
@joostdevries Thank you. |
hoped to deploy tonight but had a minor crisis to attend :-( |
hope all is well :) |