Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in 2.16 and add acceptance tests for tests #588

Merged
merged 3 commits into from
Mar 30, 2018

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Mar 29, 2018

Fixes #577

@Gaurav0 Gaurav0 requested review from pangratz and a team March 29, 2018 22:58
@Gaurav0 Gaurav0 merged commit 1131ad4 into ember-cli:master Mar 30, 2018
@Gaurav0 Gaurav0 deleted the acceptance_tests_for_tests branch March 30, 2018 06:51
@sukima
Copy link
Contributor

sukima commented Mar 30, 2018

Wow! 🎊 Thanks. I don't think I could even have come a quarter of the way to the solution that you did. I tried looking was so lost I didn't even get started trying anything. Thank you for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants