bump to ember 1.13.4 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm I consistently get an error in tests in chrome... It appears to be a race condition, and from the looks of it maybe an ember issue. ( i don't think the issue actually affects real apps, it seems maybe test related) Headless tests appear to be good though.. |
…uto-runs. This fixes issue that appeared in tests in ember 1.13.4, but isn’t really an ember
|
Looks good to me. |
|
Note: once this is deployed I can publish the component less helpers as a twiddle |
|
@stefanpenner You can start writing your gist on my branch at https://ember-twiddle-gaurav.herokuapp.com |
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 failing test, will investigate.