Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #490

Closed
wants to merge 166 commits into from
Closed

Redesign #490

wants to merge 166 commits into from

Conversation

knownasilya
Copy link
Contributor

@knownasilya knownasilya commented Oct 20, 2016

Implementation of #400 mockups by @matmac using ember-paper

Don't merge yet, this is a WIP. Goal is to get it as close to the mockups as possible, but not deviate too much from Ember Paper semantics.

TODO

  • Move to sidebar layout
  • Integrate ember-paper
  • Replace tree with https://github.com/IvyApp/ivy-tree
  • Hide sidebar on desktop
  • Finish file menu
    • Add file menu items
    • Add rename/move commands (good for someone trying to help)
    • Move gist operations to top (out of file menu) (good for someone trying to help)
    • Figure out certain nesting issues
  • Update styles (colors, icons, fonts)
  • Mobile support (flexi?)
    • Not using Flexi atm due to no Ember 2.10 support
    • Finish sidebar layout
    • Finish main screen layout when sidebar closed
  • Fix tests
  • Fix bugs

Another PR

  • Move file operation onto tree
  • Alternate layouts support
  • Save user settings (keymap mode, layout mode, etc) to gist or localstorage
  • Monaco editor integration

Screenshot updated 1/15/17

screen shot 2017-01-15 at 1 50 31 pm

@knownasilya
Copy link
Contributor Author

Here's an update:

twiddle-nav

@stefanpenner
Copy link
Contributor

@knownasilya cool, I like the mobile responsive stuff!

@alexspeller
Copy link
Member

I am super excited about this!

@Gaurav0
Copy link
Contributor

Gaurav0 commented Jan 11, 2017

@knownasilya Thanks so much for working on this!

Btw, I think you should merge master into your branch occasionally so that it doesn't become too difficult at some point.

@knownasilya
Copy link
Contributor Author

@Gaurav0 thanks :) feel free to leave feedback!
I've been trying to rebase any chance I get.

@gokatz
Copy link
Member

gokatz commented Feb 28, 2020

Hey @knownasilya, really excited to see the new design of Twiddle. Thank you so much for your time 😃 One small clarification, this PR has over 100 file changes. Won't it become tedious to review as a whole?

@knownasilya
Copy link
Contributor Author

@gokatz yeah, probably. Reviews weren't even a thing when I started this lol. I might pull it out into smaller PRs

@gokatz
Copy link
Member

gokatz commented Feb 28, 2020

Awesome 🎉 @knownasilya

@knownasilya knownasilya mentioned this pull request Feb 29, 2020
@Gaurav0
Copy link
Contributor

Gaurav0 commented Mar 13, 2020

Closing as stale.

@Gaurav0 Gaurav0 closed this Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.