Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS fixes and improvements #481

Merged
merged 17 commits into from
Sep 18, 2016
Merged

Conversation

piotrpalek
Copy link
Contributor

@piotrpalek piotrpalek commented Sep 14, 2016

The main issue I was trying to fix is that the "Run Tests" and "Live Reload" checkboxes cover each other when "Live Reload" is deselected:
Before:
image
After:
image

Other problems this will fix (discovered while fixing the first issue):

  • the header elements are consistently positioned (especially vertically) across all panes (esp. visible for eg. the on "Output" string):
    Before:
    image
    After:
    image
  • when the tree is hidden and there are 0 editor panes the page looked broken:
    Before:
    image
    After:
    image
  • I've changed how the file tree looks and behaves, it is no longer resizable and is much smaller which leaves more space for the important stuff (it still expands when the tree shifts to the right due to many items):
    Before:
    image
    After:
    image

Mobile view (only last screen has real changes so I provide a "before" screenshot there):
image
image

Fixed output pane:
Before:
image
After:
image

Edit: I think I'd add a little more spacing to the file tree (left/right) looks a bit too cramped together imo

@Gaurav0
Copy link
Contributor

Gaurav0 commented Sep 14, 2016

  1. Please don't make the file tree unresizable. Making it smaller by default would be fine.
  2. Please post mobile screenshots after changes.

@piotrpalek
Copy link
Contributor Author

piotrpalek commented Sep 14, 2016

@Gaurav0 Regarding the first question, what's the utility of being able to resize the file tree?

edit: I know text editors generally have that ability, just trying to think of a valid reason why :) And if we should provide this functionality for the file pane as well.

edit2: On the other hand I don't really feel strongly about this, if we ever want to disable the file pane dragging we can do that easily. I've restored it for now in the latest push.

@piotrpalek
Copy link
Contributor Author

piotrpalek commented Sep 14, 2016

@Gaurav0 I've updated the description with mobile screenhots. The changes are also visible here

edit: pushed a few fixes for the filepane, main one was being able to drag the pane above the tree:
image

@piotrpalek
Copy link
Contributor Author

@Gaurav0 noticed one more issue, the filepane behaves a bit weirdly when trying to shrink it below the minimum width (instead of nothing happening, the panel next to the filepane starts to grow). Let me fix that before merging.

@piotrpalek
Copy link
Contributor Author

piotrpalek commented Sep 18, 2016

@Gaurav0 I've fixed the tree issue and some additional ones:
edit: ready to merge from my side (changes reflected here as well)

  • added a scrollbar when the filepanes contents are too big
    Before:
    image
    After:
    image
  • the top toolbar was broken in mobile view when the text was too long (for eg. when displaying the revision)
    Before:
    image
    After:
    image

@Gaurav0
Copy link
Contributor

Gaurav0 commented Sep 18, 2016

Looks Awesome. Thanks!

@Gaurav0 Gaurav0 merged commit 3db3939 into ember-cli:master Sep 18, 2016
@piotrpalek piotrpalek deleted the fix-pane-header-css branch September 18, 2016 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants