-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS fixes and improvements #481
Conversation
|
@Gaurav0 Regarding the first question, what's the utility of being able to resize the file tree? edit: I know text editors generally have that ability, just trying to think of a valid reason why :) And if we should provide this functionality for the file pane as well. edit2: On the other hand I don't really feel strongly about this, if we ever want to disable the file pane dragging we can do that easily. I've restored it for now in the latest push. |
causes jumping when loading the app and isn't neccesary when filetree resizing is enabled
@Gaurav0 noticed one more issue, the filepane behaves a bit weirdly when trying to shrink it below the minimum width (instead of nothing happening, the panel next to the filepane starts to grow). Let me fix that before merging. |
125de64
to
669ba01
Compare
Looks Awesome. Thanks! |
The main issue I was trying to fix is that the "Run Tests" and "Live Reload" checkboxes cover each other when "Live Reload" is deselected:
Before:
After:
Other problems this will fix (discovered while fixing the first issue):
Before:
After:
Before:
After:
Before:
After:
Mobile view (only last screen has real changes so I provide a "before" screenshot there):
Fixed output pane:
Before:
After:
Edit: I think I'd add a little more spacing to the file tree (left/right) looks a bit too cramped together imo