Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to load a previous revision of a gist #340

Merged
merged 4 commits into from
Mar 3, 2016

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Mar 1, 2016

Issue #66

];

runGist({
type: "revision",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks weird to have a function called runGist which you can then pass an optional flag to run something else. Why not create runGistRevision?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it is weird. I did it because they were the mostly the same. I'll adjust. Thanks!

Gaurav0 added a commit that referenced this pull request Mar 3, 2016
Ability to load a previous revision of a gist
@Gaurav0 Gaurav0 merged commit 45bf9e5 into ember-cli:master Mar 3, 2016
@Gaurav0 Gaurav0 deleted the revision_route branch March 3, 2016 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants