Cleanup Responsive Navbar Menu #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2015 11:56
* Move title out of the collapsed menu * Improve collapse button colors and position * Make collapse menu items bigger for better mobile support * Fix collapse menu item positioning and add break
|
<3 |
added 2 commits
December 30, 2015 13:17
WIP on the titles The links when not in responsive mode were tiny (broke somewhere before this pr)
| <div class="title"> | ||
| {{title-input value=model.description titleChanged=(action "titleChanged")}} | ||
| {{saved-state-indicator model=model unsaved=unsaved}} | ||
| </div> |
There was a problem hiding this comment.
Title was changed before this PR, so now it blocks clicking on the navlinks when above the collapse threshold and below ~1500px, see canary.ember-twiddle.com
Not sure on how to fix this yet, looking at the old styles, but it doesn't seem obvious.
|
Accepting because this is a huge improvement and @knownasilya says he does not have time to complete. |
Gaurav0
added a commit
that referenced
this pull request
Dec 30, 2015
Cleanup Responsive Navbar Menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294
TODO