Don't set version for {{user-menu}} in twiddles template #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version is read from the config inside the {{user-menu}} component,
so there is no need to pass it.
Also, this is a leftover from 55e5f89,
where the {{user-menu}} has been added to the toolbar but there is no
`version` property set on the controller.
Gaurav0
added a commit
that referenced
this pull request
Oct 28, 2015
Don't set version for {{user-menu}} in twiddles template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version is read from the config inside the {{user-menu}} component,
so there is no need to pass it.
Also, this is a leftover from 55e5f89,
where the {{user-menu}} has been added to the toolbar but there is no
versionproperty set on the controller.This fixes the weird
Ember Twiddle vmenu item on/twiddles: