-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty icons and tooltips #189
Conversation
Can you attach before/after screenshots? |
Yeah I'll fix the tests and make some ss. |
Side Note: I can't figure out how to run the tests locally. I get 37 fails locally. All my changes are in peach-ish bar. The close, add a pane, show/hide file tree, and collapse/expand icons. The tool tips for these as well. I changed the expand/collapse icons because they suggest a maximizing/minimizing of the file tree pane rather than expanding/collapsing the folders within. The old tooltips also took quite a while to appear and could potentially be overlooked. CurrentThis PR |
fancy! |
@@ -45,8 +45,15 @@ module.exports = function() { | |||
}); | |||
|
|||
app.import('bower_components/ember/ember-template-compiler.js'); | |||
app.import('vendor/hint.min.css'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please import the unminified version. Ember CLI will minify in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need to compile this. I'll see if I still have the files or make a new one.
Let me know any thoughts or suggestions since I kind of just went off on my own here.
I also deleted
application.hbs
. It didn't see to be being used(in favor of the pods styleapplication/template.hbs
) but maybe there was something I didn't understand?