Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty icons and tooltips #189

Merged
merged 4 commits into from
Sep 15, 2015
Merged

Conversation

KTKate
Copy link
Contributor

@KTKate KTKate commented Sep 6, 2015

Let me know any thoughts or suggestions since I kind of just went off on my own here.

I also deleted application.hbs. It didn't see to be being used(in favor of the pods style application/template.hbs) but maybe there was something I didn't understand?

@rwjblue
Copy link
Member

rwjblue commented Sep 6, 2015

Can you attach before/after screenshots?

@KTKate
Copy link
Contributor Author

KTKate commented Sep 6, 2015

Yeah I'll fix the tests and make some ss.

@KTKate
Copy link
Contributor Author

KTKate commented Sep 6, 2015

Side Note: I can't figure out how to run the tests locally. I get 37 fails locally.

All my changes are in peach-ish bar. The close, add a pane, show/hide file tree, and collapse/expand icons. The tool tips for these as well. I changed the expand/collapse icons because they suggest a maximizing/minimizing of the file tree pane rather than expanding/collapsing the folders within. The old tooltips also took quite a while to appear and could potentially be overlooked.

Current

twiddleold

This PR

twiddlenew

@stefanpenner
Copy link
Contributor

fancy!

@@ -45,8 +45,15 @@ module.exports = function() {
});

app.import('bower_components/ember/ember-template-compiler.js');
app.import('vendor/hint.min.css');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import the unminified version. Ember CLI will minify in production.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to compile this. I'll see if I still have the files or make a new one.

Gaurav0 added a commit that referenced this pull request Sep 15, 2015
@Gaurav0 Gaurav0 merged commit 6adf10f into ember-cli:master Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants