set first column active on load #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,6 +113,7 @@ export default Ember.Controller.extend({ | |||
| controller: this | |||
| })); | |||
| } | |||
| columns.objectAt(0).set('active', true); | |||
There was a problem hiding this comment.
Column#active is a computed property with no setter.
The correct way to make a column active is to set activeEditorCol on the controller.
|
This PR causes the first column to always be active. |
|
@Gaurav0 thanks for the insight. edited based on your suggestion. |
Gaurav0
added a commit
that referenced
this pull request
Aug 24, 2015
set first column active on load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change, but currently when page loads and code panes are greyed out, can give impression that twiddle is disabled. This seeks to highlights that is editable and people can jump right in.