Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Forking and Saving #157

Merged
merged 2 commits into from
Aug 16, 2015
Merged

Improve Forking and Saving #157

merged 2 commits into from
Aug 16, 2015

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Aug 16, 2015

  1. The fork menu option now no longer appears unless you do not own the gist
  2. The save option forks if you do not own the gist

Relevant to issue #153

@stefanpenner
Copy link
Contributor

SGTM – :shipit:

Gaurav0 added a commit that referenced this pull request Aug 16, 2015
@Gaurav0 Gaurav0 merged commit 7202a93 into ember-cli:master Aug 16, 2015
@chancancode
Copy link

Can we add back a way to fork your own twiddle? I find myself wanting to do it quite often for various reasons: creating stable "steps" I can embed in a long tutorial, having a base template to build off of, etc. I would even take something like "hold down option key to change save to fork" :) (But I think it is still quite legitimate that you would want to fork your own twiddle, so I don't think it needs to be a hidden/advanced feature)

Also, I have a UI suggestion along the same lines: The file menu currently mixes commands that operates on file-level (add/move/delete) vs things that operates on the twiddle level (new/save/fork/share). Maybe move the latter above the divider to separate the two sets of things?

(Actually, it's already supposed to work that way: there is a bug though, when you are not authenticated, it doesn't show the divider)

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Sep 8, 2015

The github api does not provide a way to fork one's own gist, it just returns an error if you try to do so. An issue is open for duplicating one's own gist, but it will likely be a copy, not a fork with a link to the original or ability to PR.

@Gaurav0 Gaurav0 deleted the fork_or_save branch September 8, 2015 15:26
@chancancode
Copy link

👍 that actually works well for my purpose, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants