Merge pull request #674 from Gaurav0/update_ember_To_3.8

Update ember to 3.8

.eslintignore

@@ -8,10 +8,12 @@
 
 # dependencies
 /bower_components/
+/node_modules/
 
 # misc
 /coverage/
 /gatekeeper/
+!.*
 
 # ember-try
 /.node_modules.ember-try/

.eslintrc.js

@@ -26,12 +26,14 @@ module.exports = {
     // node files
     {
       files: [
+        '.eslintrc.js',
         '.template-lintrc.js',
         'ember-cli-build.js',
         'testem.js',
         'blueprints/*/index.js',
         'config/**/*.js',
-        'lib/*/index.js'
+        'lib/*/index.js',
+        'server/**/*.js'
       ],
       parserOptions: {
         sourceType: 'script',

.gitignore

@@ -12,6 +12,8 @@
 /node_modules/
 
 # misc
+/.env*
+/.pnp*
 /.sass-cache
 /connect.lock
 /coverage/

app/models/gist-revision.js

@@ -1,3 +1,12 @@
+import DS from 'ember-data';
 import GistModel from "./gist";
 
-export default GistModel.extend();
+const { attr } = DS;
+
+export default GistModel.extend({
+  revId: attr('string'),
+
+  generateIdForRecord() {
+    return this.id + '+' + this.revId;
+  }
+});

app/routes/gist/edit.js

@@ -8,7 +8,7 @@ export default GistRoute.extend({
   model(params) {
     run(() => pushDeleteAll(this.store, 'gist-file'));
 
-    return this.store.find('gist', params.gistId);
+    return this.store.findRecord('gist', params.gistId);
   },
 
   setupController() {

config/deprecation-workflow.js

@@ -1,7 +1,9 @@
 self.deprecationWorkflow = self.deprecationWorkflow || {};
 self.deprecationWorkflow.config = {
   workflow: [
+    { handler: "silence", matchId: "deprecate-router-events" },
     { handler: "silence", matchId: "ember-runtime.deprecate-copy-copyable" },
+    { handler: "silence", matchId: "ember-polyfills.deprecate-merge" },
     { handler: "silence", matchId: "ember-data:method-calls-on-destroyed-store" },
     { handler: "silence", matchId: "ember-component.send-action" }
   ]

package.json

@@ -34,17 +34,17 @@
     "browserify": "^16.2.0",
     "compare-versions": "^3.2.1",
     "dedent": "~0.7.0",
-    "ember-ajax": "^3.1.0",
+    "ember-ajax": "^5.0.0",
     "ember-api-actions": "~0.1.8",
     "ember-autoresize": "~0.6.1",
-    "ember-cli": "~3.4.4",
+    "ember-cli": "~3.8.3",
     "ember-cli-app-version": "^3.2.0",
-    "ember-cli-babel": "^6.16.0",
+    "ember-cli-babel": "^7.1.2",
     "ember-cli-bootstrap-sassy": "~0.5.8",
     "ember-cli-build-notifications": "~0.4.0",
     "ember-cli-cjs-transform": "^1.3.0",
     "ember-cli-code-coverage": "~0.4.2 ",
-    "ember-cli-dependency-checker": "^3.0.0",
+    "ember-cli-dependency-checker": "^3.1.0",
     "ember-cli-deploy": "^1.0.2",
     "ember-cli-deploy-s3-pack": "^1.0.0-beta.2",
     "ember-cli-deploy-slack": "^1.0.0",
@@ -62,7 +62,6 @@
     "ember-cli-moment-shim": "^3.7.1",
     "ember-cli-node-assets": "~0.2.2",
     "ember-cli-preprocess-registry": "^3.1.1",
-    "ember-cli-qunit": "^4.4.0",
     "ember-cli-release": "1.0.0-beta.2",
     "ember-cli-sass": "^6.2.0",
     "ember-cli-shims": "~1.1.0",
@@ -71,7 +70,7 @@
     "ember-cli-test-loader": "^2.2.0",
     "ember-cli-uglify": "^2.1.0",
     "ember-concurrency": "~0.8.17",
-    "ember-data": "~3.4.0",
+    "ember-data": "~3.8.0",
     "ember-disable-proxy-controllers": "^1.0.1",
     "ember-export-application-global": "^2.0.0",
     "ember-git-version": "~0.1.2",
@@ -83,11 +82,12 @@
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-moment": "^7.6.0",
     "ember-notify": "^5.2.1",
+    "ember-qunit": "^3.4.1",
     "ember-resolver": "^4.0.0",
     "ember-responsive": "^2.0.8",
     "ember-rfc176-data": "~0.3.2",
     "ember-route-action-helper": "^2.0.6",
-    "ember-source": "~3.4.0",
+    "ember-source": "~3.8.0",
     "eslint-plugin-ember": "^5.2.0",
     "file-saver": "^2.0.2",
     "ivy-codemirror": "IvyApp/ivy-codemirror#ff753f16557a7b222737575c66b3ae3ae7d484ce",

tests/acceptance/git-revision-test.js

@@ -77,6 +77,12 @@ module('Acceptance | gist-revision', function(hooks) {
       {
         filename: "application.template.hbs",
         content: "Hello, World!"
+      },
+      {
+        filename: "twiddle.json",
+        content: `{
+                    "dependencies": {}
+                  }`
       }
     ];
 
@@ -89,6 +95,12 @@ module('Acceptance | gist-revision', function(hooks) {
         {
           filename: "application.template.hbs",
           content: "Hello, ..."
+        },
+        {
+          filename: "twiddle.json",
+          content: `{
+                      "dependencies": {}
+                    }`
         }
       ],
       type: 'revision',