Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/npm-adapter: Use async/await instead of promise chains #788

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 4, 2021

This should make the test code a little easier on the eyes :)

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #788 (01179f5) into master (cb5f901) will decrease coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   95.46%   94.44%   -1.02%     
==========================================
  Files          16       17       +1     
  Lines         463      558      +95     
==========================================
+ Hits          442      527      +85     
- Misses         21       31      +10     
Impacted Files Coverage Δ
lib/utils/dependency-manager-adapter-factory.js 90.62% <0.00%> (-4.38%) ⬇️
lib/dependency-manager-adapters/pnpm.js 90.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb5f901...01179f5. Read the comment docs.

@kategengler kategengler merged commit 1ee8f6d into ember-cli:master Nov 6, 2021
@kategengler
Copy link
Member

Thank you!

@Turbo87 Turbo87 deleted the async-tests branch November 6, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants