Update deps and drop Node 4 support #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 16 16
Lines 491 491
=======================================
Hits 472 472
Misses 19 19
Continue to review full report at Codecov.
|
kategengler
force-pushed
the
kg-update-deps
branch
from
a742f64 to
820b5e5
Compare
btecu
reviewed
Aug 29, 2018
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "repository": "ember-cli/ember-try", | |||
| "engines": { | |||
| "node": "^4.5 || 6.* || >= 7.*" | |||
| "node": "6.* || >= 7.*" | |||
There was a problem hiding this comment.
7 is no longer supported, it should be 6, 8 and 10: "6.* || 8.* || >= 10.*"
There was a problem hiding this comment.
I have a follow-on PR to update the blueprint, just fixed it enough so that tests would run.
kategengler
force-pushed
the
kg-update-deps
branch
from
57f11a4 to
f0bf55d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.