Leverage command return value instead of process.exit. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
commented
Feb 19, 2017
| task._on('SIGINT', function() { | ||
| if (shutdownCount === 0) { |
There was a problem hiding this comment.
FWIW, this two phase exit system will not work on recent ember-cli anyways because process.exit() no longer ensures immediate exit (as it did before).
rwjblue
force-pushed
the
use-command-return-value-for-exit-code
branch
from
5550cb8
to
9971720
Compare
|
Before this PR (when using ember-cli#master) a failing test suite with You can test using the demo repo I created for ember-cli/ember-cli#6779 (https://github.com/rwjblue/exit-code-incorrect-demo). |
Works around an upstream issue in ember-cli 2.13 canary versions, and is quite a bit easier to test. Also tweaked SIGINT handling to queue up a cancel and avoid additional work. This is because in ember-cli 2.9+ we use `capture-exit` so that `process.exit()` does not immediately schedule an exit any longer (so the semantics that we intended with the prior SIGINT logic were generally broken already).
rwjblue
force-pushed
the
use-command-return-value-for-exit-code
branch
from
9971720
to
9d663eb
Compare
|
FWIW, I also confirmed as far back as [email protected] that returning an exit code from a command would affect the resulting process exit code, so this is not a backwards breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around an upstream issue in ember-cli 2.13 canary versions, and is quite a bit easier to test.
Also tweaked SIGINT handling to queue up a cancel and avoid additional work. This is because in ember-cli 2.9+ we use
capture-exitso thatprocess.exit()does not immediately schedule an exit any longer (so the semantics that we intended with the prior SIGINT logic were generally broken already).Addresses the issue identified in ember-cli/ember-cli#6779.