Fix Main Service Lookup #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was ignoring main when it was in the specifier name, However we should only ignore if it is in the name AND collection. This is meant to avoid looking up main twice for example /my-app/src/router/main/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mixonic @dgeb This PR fixes the RequireJS Registry for main services/components.
Previously we were ignoring the name 'main'. This was to avoid lookups with something like
/my-app/src/router/main/main. However really we should ignore main if it is the name AND collection, and allow the name when the collection is something else.This allows me to name the service "main" in the
mu-golden-spikeapp.I also added the
'template-options'type to config since this seems to be a new thing in Ember.Fixes glimmerjs/glimmer-resolver#25