-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement resolveEngine and resolveRouteMap #151
Conversation
Using the stamp seems totally fine to me. Can you add a test for that assertion though? |
ef0556b
to
19f6853
Compare
@rwjblue added a test |
My only concern is that this sneaks by the feature flag and exists as "dormant" code in apps the moment we release a new version. I'm tempted to delay landing + release until the feature flag is removed. |
(Note: code is perfectly reasonable.) |
@nathanhammond I'm not sure I agree. Since Ember Beta is currently running with the feature flag enabled by default, I think now would be a good time to start testing this out as well. We can release a beta version of this addon if needed, but I think we should try to have this working by the time Engines are released in 2.8 (so that we can encourage this pattern over the custom resolver provided by the ember-engines addon). |
The fact that it'd be a beta of a point release feels ridiculous, but I'd rather match the current Ember beta progress. @rwjblue is the only one with publish privs, so it'll be his call. 😛 |
So @rwjblue does that mean this can land 😉 |
Released as v2.1.0 |
I now relinquish my stick in the mud position. 😄 |
@rwjblue You should probably point out somewhere that this release doesn't work with engines < 0.3.0 |
Addressing ember-engines/ember-engines#10.
One change to note: The
route-map
lookup now expects anisRouteMap
property instead of trying to share a symbol between this addon and ember-engines.cc @dgeb @rwjblue @nathanhammond