-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript conversion so we have accurately generated types for consumers #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
added a commit
that referenced
this pull request
Dec 27, 2023
NullVoxPopuli
changed the base branch from
master
to
pull-forward-lint-changes-from-ts-branch
December 27, 2023 17:31
NullVoxPopuli
force-pushed
the
typescript-take-two
branch
from
December 27, 2023 17:33
2ebcebc
to
e6cd893
Compare
NullVoxPopuli
force-pushed
the
typescript-take-two
branch
from
December 28, 2023 14:53
0038b76
to
3fdafd3
Compare
NullVoxPopuli
added a commit
that referenced
this pull request
Dec 28, 2023
NullVoxPopuli
added a commit
that referenced
this pull request
Dec 28, 2023
…-ts-branch Pull forward the lint changes from #275
Base automatically changed from
pull-forward-lint-changes-from-ts-branch
to
master
December 28, 2023 15:04
NullVoxPopuli
force-pushed
the
typescript-take-two
branch
from
December 28, 2023 15:05
3fdafd3
to
07fae77
Compare
NullVoxPopuli
commented
Jan 8, 2024
@@ -6,6 +6,6 @@ | |||
{{@title}} | |||
</header> | |||
<div> | |||
{{yield this}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a template-only component, and thus has no this
wagenet
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't verify every single line, but the overall direction looks correct to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 3 PRs should be merged first:
As ember has first-class TypeScript support out of the box (almost), we need to to have all core addons also support that.
Like always, consumers don't need to use TypeScript, but our library code using TypeScript will provide better intellisense for both JavaScript and TypeScript users.
Incidentally, achieving more alignment with the TS-v2-addon blueprint, we gain support for Glint-using projects.
This work continues the work of #246
Demo in the docs app:
Changes:
npx ember-apply typescript
to the docs app