Fix release, beta and canary scenarios #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
fix-ci
branch
2 times, most recently
from
c993647
to
7aeca84
Compare
NullVoxPopuli
approved these changes
Aug 16, 2023
knownasilya
added
the
breaking
|
@knownasilya Don't think these changes should be labelled as breaking. |
|
You did update the node version and some of the import paths, I think those are breaking. I might be wrong.. |
|
I only updated the pinned Node version using Volta to make CI happy (I did not update |
knownasilya
added
Cleanup
and removed
breaking
|
si, this is a browser-only v2 addon, so node version has no impact on consumers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.