Update to ember-source 5.1 types (and other fixes) #256

leepfrog · 2023-07-21T21:20:33Z

global.d.ts: Change global type defintions to import ember-source/types and ember-cli-fastboot
package.json: Remove @types/ember*
package.json: Update @embroider/addon-dev to 3.2.0
package.json: Replace babel-eslint with @babel/eslint-parser to address deprecation warning
package.json: Add @simple-dom/document to import types
package.json: Add ember-source to import types
helpers/page-title.ts: Refactor object to Owner for constructor()
services/page-title.ts: Add guards for potential undefined variables
services/page-title.ts: Update import to address ember deprecation
tsconfig.json: Add support for experimental decorators (ie @service)

…ypes and ember-cli-fastboot - package.json: Remove @types/ember* - package.json: Update @embroider/addon-dev to 3.2.0 - package.json: Replace babel-eslint with @babel/eslint-parser to address deprecation warning - package.json: Add @simple-dom/document to import types - package.json: Add ember-source to import types - helpers/page-title.ts: Refactor `object` to `Owner` for `constructor()` - services/page-title.ts: Add guards for potential undefined variables - services/page-title.ts: Update import to address ember deprecation - tsconfig.json: Add support for experimental decorators (ie `@service`)

addon/dev-only-types/global.d.ts

knownasilya · 2023-07-21T21:34:46Z

Looks like an install error, I think we can update to node 16 here esp since new addons start at node 16

leepfrog · 2023-07-21T23:49:18Z

I think this has another outdated dependency or configuration issue 👀 :

$ 
> yarn install
yarn install v1.22.19
[1/4] 🔍  Resolving packages...
success Already up-to-date.
$ cd addon && yarn build
yarn run v1.22.19
$ rollup --config
(!) You have passed an unrecognized option
Unknown output options: experimentalMinChunkSize. Allowed options: amd, assetFileNames, banner, chunkFileNames, compact, dir, dynamicImportFunction, entryFileNames, esModule, exports, extend, externalLiveBindings, file, footer, format, freeze, generatedCode, globals, hoistTransitiveImports, indent, inlineDynamicImports, interop, intro, manualChunks, minifyInternalExports, name, namespaceToStringTag, noConflict, outro, paths, plugins, preferConst, preserveModules, preserveModulesRoot, sanitizeFileName, sourcemap, sourcemapBaseUrl, sourcemapExcludeSources, sourcemapFile, sourcemapPathTransform, strict, systemNullSetters, validate

 → dist...
[!] (plugin Typescript) TypeError: nodes is not iterable
TypeError: nodes is not iterable
    at visitNodes (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:27715:26)
    at forEachChildInTypeAliasDeclaration (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:28408:98)
    at Object.forEachChild (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:27801:37)
    at fixupParentReferences (ember-cli/ember-page-title/node_modules/ts-clone-node/src/clone-node/util/set-parents.ts:8:13)
    at setParents (ember-cli/ember-page-title/node_modules/ts-clone-node/src/clone-node/util/set-parents.ts:31:2)
    at executePreserveNode (ember-cli/ember-page-title/node_modules/ts-clone-node/src/clone-node/clone-node.ts:333:2)
    at Module.preserveNode (ember-cli/ember-page-title/node_modules/ts-clone-node/src/clone-node/clone-node.ts:265:2)
    at preserveMeta (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/util/clone-node-with-meta.ts:17:9)
    at visitTypeAliasDeclaration (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/transformers/ensure-no-export-modifier-transformer/visitor/visit-type-alias-declaration.ts:9:9)
    at visitNode (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/transformers/ensure-no-export-modifier-transformer/visitor/visit-node.ts:27:10)
    at Object.continuation (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/transformers/ensure-no-export-modifier-transformer/ensure-no-export-modifier-transformer.ts:32:4)
    at ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/transformers/ensure-no-export-modifier-transformer/ensure-no-export-modifier-transformer.ts:39:68
    at visitArrayWorker (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:85983:51)
    at visitNodes2 (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:85954:21)
    at visitLexicalEnvironment (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:86010:18)
    at visitEachChildOfSourceFile (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:87199:13)
    at Object.visitEachChild (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:86171:35)
    at ensureNoExportModifierTransformer (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/transformers/ensure-no-export-modifier-transformer/ensure-no-export-modifier-transformer.ts:39:14)
    at applyTransformers (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/util/apply-transformers.ts:12:31)
    at ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/transformer/declaration-bundler/transformers/source-file-bundler/source-file-bundler.ts:119:32
    at transformation (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:109610:16)
    at transformRoot (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:109633:73)
    at transformNodes (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:109618:72)
    at emitDeclarationFileOrBundle (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:110256:36)
    at emitSourceFileOrBundle (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:110143:7)
    at forEachEmittedFile (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:109886:24)
    at emitFiles (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:110114:5)
    at emitWorker (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:117550:26)
    at ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:117535:53
    at runWithCancellationToken (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:117624:16)
    at Object.emit (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:117535:22)
    at emitNextAffectedFile (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:121249:36)
    at Object.emit (ember-cli/ember-page-title/node_modules/typescript/lib/typescript.js:121370:39)
    at runEmit (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/compiler-host/compiler-host.ts:111:6)
    at CompilerHost.emit (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/compiler-host/compiler-host.ts:124:3)
    at bundleDeclarationsForChunk (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/emit/declaration/bundle-declarations-for-chunk.ts:14:34)
    at emitDeclarations (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/service/emit/declaration/emit-declarations.ts:174:24)
    at Object.generateBundle (ember-cli/ember-page-title/node_modules/rollup-plugin-ts/src/plugin/typescript-plugin.ts:573:5)
    at ember-cli/ember-page-title/node_modules/rollup/dist/shared/rollup.js:22879:40

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

- package.json: add `--bundleConfigAsCjs` to `rollup` - rollup.config.js: rename to rollup.config.mjs (as instructed from warning message) Renamed rollup.config.js to rollup.config.mjs - Updated rollup package to latest version - Added `--bundle

leepfrog · 2023-07-22T00:01:25Z

Ok, I think this is going to work now? 🤞

knownasilya · 2023-07-23T01:00:26Z

@leepfrog running..

leepfrog · 2023-07-23T02:08:26Z

Ah, tests are failing because the test-app is older ember.

either can:

update test app to be newer (currently 3.28lts — basically dropping older ember support)
revert the change of the import path for getOwner (incurring future technical debt due to deprecation) and continue to use older import location

lemme know which is preferred and I can make the changes!

knownasilya · 2023-07-23T22:34:11Z

Lets update the test app

leepfrog · 2023-07-26T23:13:27Z

I got stuck on a different issue. I'm getting an error when the PageTitleService attempts to inject the Router Service (in its constructor):

Error: Assertion Failed: Attempting to lookup an injected property on an object without a container, ensure that the object was instantiated via a container.

I started a thread on discord #help to see if I can get a hand on this.

… call - test-app/config/ember-try: remove support for ember 3 & ember 4 lts versions - test-app/package.json: update ember-source and ember-resolver versions

leepfrog · 2023-07-27T00:35:28Z

Removed support for ember-3/ember-4 in the test-app and fixed a bug in the PageTitleService.

All of the tests are now running locally for me, so.. maybe this time it'll work? :)

- Fix ember-source version - Change `Owner` import to type import

leepfrog · 2023-07-27T02:08:12Z

There's a build error when using CI=true -- going to look into that and hopefully that'll be the last thing!

knownasilya · 2023-07-27T03:11:15Z

Running test, lets see what happens

leepfrog · 2023-07-27T05:16:10Z

There were enough small options / configuration changes that it made sense to just regenerate the test-app from the new blueprint and move over the tests. So.. did that.

I also locally spun up into an ubuntu docker image and ran with the same CI=true yarn test:ember -- this works now!

- test-app/tests: refactor to use strictEqual instead of equal - test-app/package.json: remove unused dependencies

- docs/package.json: update ember-source version, add @ember/strings

…libraries

leepfrog · 2023-07-27T07:51:28Z

I didn't realize the CI was also running on my local fork 😅 -- but I was able to use it to get all of the steps green! Should be good to re-run now.

This was referenced Jul 21, 2023

Convert to TS or supply ambient definitions #239

Closed

feat: typescript #246

Closed

knownasilya reviewed Jul 21, 2023

View reviewed changes

addon/dev-only-types/global.d.ts Show resolved Hide resolved

- Remove node v14

e42f2e9

- addon/src/services/page-title: add missing ...attributes to super()…

7f8c94a

… call - test-app/config/ember-try: remove support for ember 3 & ember 4 lts versions - test-app/package.json: update ember-source and ember-resolver versions

- Remove unused lockfile

1a0d698

- Fix ember-source version - Change `Owner` import to type import

- test-app: re-generate from current ember-cli blueprint

83d90db

- test-app/tests: refactor to use strictEqual instead of equal - test-app/package.json: remove unused dependencies

leepfrog force-pushed the fix-ci branch from 68da2b0 to 83d90db Compare July 27, 2023 05:28

leepfrog added 7 commits July 26, 2023 23:02

- test-app/package.json: remove css linting

77d5acb

ci: remove ember-classic from ember-try, change docs version to 16

6499aec

- docs/app/helpers/highlight: update import paths

01580f0

- docs/package.json: update ember-source version, add @ember/strings

- docs/*: refactor to use ember-source 5.1.2

9070585

addon: update eslint/ts build settings

d154e4c

addon: update ts build settings to exclude typechecking of 3rd party …

472b932

…libraries

docs: update tests to strictEqual

f94e9b9

knownasilya merged commit 48c4daa into ember-cli:typescript Jul 27, 2023
15 checks passed

kategengler added the enhancement label Aug 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to ember-source 5.1 types (and other fixes) #256

Update to ember-source 5.1 types (and other fixes) #256

leepfrog commented Jul 21, 2023

knownasilya commented Jul 21, 2023

leepfrog commented Jul 21, 2023

leepfrog commented Jul 22, 2023

knownasilya commented Jul 23, 2023

leepfrog commented Jul 23, 2023 •

edited

Loading

knownasilya commented Jul 23, 2023

leepfrog commented Jul 26, 2023

leepfrog commented Jul 27, 2023

leepfrog commented Jul 27, 2023

knownasilya commented Jul 27, 2023

leepfrog commented Jul 27, 2023 •

edited

Loading

leepfrog commented Jul 27, 2023

Update to ember-source 5.1 types (and other fixes) #256

Update to ember-source 5.1 types (and other fixes) #256

Conversation

leepfrog commented Jul 21, 2023

knownasilya commented Jul 21, 2023

leepfrog commented Jul 21, 2023

leepfrog commented Jul 22, 2023

knownasilya commented Jul 23, 2023

leepfrog commented Jul 23, 2023 • edited Loading

knownasilya commented Jul 23, 2023

leepfrog commented Jul 26, 2023

leepfrog commented Jul 27, 2023

leepfrog commented Jul 27, 2023

knownasilya commented Jul 27, 2023

leepfrog commented Jul 27, 2023 • edited Loading

leepfrog commented Jul 27, 2023

leepfrog commented Jul 23, 2023 •

edited

Loading

leepfrog commented Jul 27, 2023 •

edited

Loading