fix ArrayBuffer support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm... looks like PhantomJS doesn't support ArrayBuffer, which makes this pretty difficult to test. Does anyone have thoughts on how to proceed? |
rwjblue
reviewed
Dec 15, 2017
| @@ -79,6 +79,30 @@ test('posting a form', function(assert) { | |||
| assert.equal(data.name, 'World'); | |||
| }); | |||
| }); | |||
| test('posting an array buffer', function(assert) { | |||
There was a problem hiding this comment.
Wrap this test in an if (typeof ArrayBuffer !== ‘undefined’) {, which will get the tests passing on phantom (by not running this one) and on chrome...
mohanyin
force-pushed
the
fix-arraybuffer-support
branch
from
32d5c0f
to
7fd45a0
Compare
|
I think CI was just fixed in #95, can you rebase (so we can confirm AppVeyor is passing properly)? |
mohanyin
force-pushed
the
fix-arraybuffer-support
branch
from
7fd45a0
to
59a6022
Compare
mohanyin
force-pushed
the
fix-arraybuffer-support
branch
from
59a6022
to
6f9837d
Compare
|
@rwjblue mind taking another look? |
rwjblue
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this library doesn't let you send
ArrayBuffers using fetch, even though the underlying polyfill supports it.