add FormData support to fastboot #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchak
force-pushed
the
form-data
branch
2 times, most recently
from
53cb14b
to
7b7f37c
Compare
|
Can you add tests? |
|
@kratiahuja right now there is no tests for fastboot in |
|
@tchak anything we can do to close this one out? |
|
@stefanpenner ideally? Find a way to run unit/integration tests in fastboot. But I guess we will have to add more acceptance tests (for addon as this on it's really not practical) and run them in fastboot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do expose
FormDatain the browser so it make sens to me to expose it also in fastboot.