Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ember-fetch against an embroider build #554

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kiwiupover
Copy link

@kiwiupover kiwiupover commented Aug 22, 2020

Adding a test scenario to test ember-fetch against embroider.

The Embroider tests are failing due to duplicates babel plugins.

info Reasons this module exists
   - "ember-cli-typescript" depends on it
   - Hoisted from "ember-cli-typescript#@babel#plugin-proposal-optional-chaining"
   - Hoisted from "@embroider#webpack#@babel#plugin-proposal-optional-chaining"
   - Hoisted from "ember-cli-babel#@babel#preset-env#@babel#plugin-proposal-optional-chaining"
Duplicates detected are:
[
  {
    "alias": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
    "dirname": "/home/travis/build/ember-cli/ember-fetch",
    "ownPass": false,
    "file": {
      "request": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
      "resolved": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js"
    }
  },
  {
    "alias": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
    "dirname": "/home/travis/build/ember-cli/ember-fetch",
    "ownPass": false,
    "file": {
      "request": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
      "resolved": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js"
    }
  }
]

@kiwiupover kiwiupover changed the title Test ember-fetch an embroider build Test ember-fetch against an embroider build Aug 22, 2020
@GCheung55
Copy link

GCheung55 commented Aug 25, 2020

@kiwiupover this issue may be related to embroider-build/embroider#453.

Can you try updating ember-typescript to 4-alpha?

@GCheung55
Copy link

Did updating ember-typescript address the problem?

Also @embroider/core doesn’t seem to be directly imported so that can be removed right?

@kiwiupover kiwiupover closed this Aug 28, 2020
@kiwiupover kiwiupover reopened this Aug 28, 2020
@kiwiupover kiwiupover closed this Aug 31, 2020
@kiwiupover kiwiupover reopened this Aug 31, 2020
@kiwiupover kiwiupover closed this Sep 3, 2020
@kiwiupover kiwiupover reopened this Sep 3, 2020
@@ -35,7 +35,7 @@
"calculate-cache-key-for-tree": "^2.0.0",
"caniuse-api": "^3.0.0",
"ember-cli-babel": "^7.19.0",
"ember-cli-typescript": "^3.1.3",
"ember-cli-typescript": "^4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be split out, I think. It seems unrelated to the overall goal of testing Embroider.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But updating the dependency addressed an issue where Babel detected duplicate plugins.

@kiwiupover
Copy link
Author

@rwjblue I have added a new PR to update ember-cli-typescript to 4.0.0 #563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants