-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test ember-fetch against an embroider build #554
base: main
Are you sure you want to change the base?
Conversation
@kiwiupover this issue may be related to embroider-build/embroider#453. Can you try updating ember-typescript to 4-alpha? |
Did updating ember-typescript address the problem? Also |
@@ -35,7 +35,7 @@ | |||
"calculate-cache-key-for-tree": "^2.0.0", | |||
"caniuse-api": "^3.0.0", | |||
"ember-cli-babel": "^7.19.0", | |||
"ember-cli-typescript": "^3.1.3", | |||
"ember-cli-typescript": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be split out, I think. It seems unrelated to the overall goal of testing Embroider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But updating the dependency addressed an issue where Babel detected duplicate plugins.
Adding a test scenario to test ember-fetch against embroider.
The Embroider tests are failing due to duplicates babel plugins.