Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against rawArgs being undefined #3155

Merged
merged 1 commit into from
Feb 10, 2015

Conversation

chadhietala
Copy link
Member

I'm not sure if this is the right fix for #3142. I'm not even sure rawArgs is used for since I ran a bunch of generators to see what it what it's value was. It seemed to always be undefined. @rwjblue, @stefanpenner, or @bcardarella can you drop some knowledge bombs on this?

This makes the message go away but I'm not sure what is the root cause. Traced it all the way back to _locals. It only effects bower.

@cibernox
Copy link
Contributor

cibernox commented Feb 8, 2015

I faced this too. My main suspect what the normalizeEntityName: function() {}, of a blueprint of an addon I was installing.

Does that makes any sense?

@trabus
Copy link
Contributor

trabus commented Feb 9, 2015

I think this is related to some work on ember init that I did a while back. To allow a glob pattern to be used to define which files to init, a targetFiles array is passed in, in addition to the rawArgs here so we can use it for the message you're seeing.

I'm not sure why an addon install is coming up with 0 files to process, but that would definitely be the reason the message comes up. Checking for the existence of rawArgs is probably the easiest path to fixing it, but I'd definitely like to understand why an addon install is behaving that way.

@stefanpenner
Copy link
Contributor

cc @jgwhite

@jgwhite
Copy link
Contributor

jgwhite commented Feb 10, 2015

Pretty sure @trabus is right and this is the correct fix. Merging.

jgwhite added a commit that referenced this pull request Feb 10, 2015
Guard against rawArgs being undefined
@jgwhite jgwhite merged commit e6b477f into ember-cli:master Feb 10, 2015
@chadhietala chadhietala deleted the globpattern-error branch February 10, 2015 16:33
@trabus
Copy link
Contributor

trabus commented Feb 10, 2015

I just figured out why the blueprint was being processed with no files: it didn't have any to process. The blueprint simply installed a bower package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants