Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve boot by 300ms -> 400ms #2901

Merged
merged 1 commit into from
Jan 22, 2015
Merged

improve boot by 300ms -> 400ms #2901

merged 1 commit into from
Jan 22, 2015

Conversation

stefanpenner
Copy link
Contributor

No description provided.

@jakecraige
Copy link
Member

Would it be possible to add a test for boot time perf? That would be a great way to watch for regressions

@stefanpenner
Copy link
Contributor Author

Would it be possible to add a test for boot time perf? That would be a great way to watch for regressions

CI server is pretty crappy re: perf. But maybe a test we can run only locally?

@jakecraige
Copy link
Member

Yeah I guess the system perf affects the test :/ But yeah, some way to easily check it / keep an eye on it in a consistent format would be nice

@stefanpenner stefanpenner self-assigned this Jan 6, 2015
@stefanpenner
Copy link
Contributor Author

apparently i can't program, will investigate these failures after work... "(unless someone has time to look earlier)"

@stefanpenner
Copy link
Contributor Author

Yeah I guess the system perf affects the test :/ But yeah, some way to easily check it / keep an eye on it in a consistent format would be nice

i gave this some thought, how about a test that only run when CI=false ?

@jakecraige
Copy link
Member

Sounds fine to me 👍

stefanpenner added a commit that referenced this pull request Jan 22, 2015
@stefanpenner
Merge pull request #2901 from ember-cli/boot-improvement
050b949 
improve boot by 300ms -> 400ms
@stefanpenner stefanpenner merged commit 050b949 into master Jan 22, 2015
@stefanpenner stefanpenner deleted the boot-improvement branch January 22, 2015 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stefanpenner stefanpenner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @jakecraige