Add isAtOrAbove and assertAtOrAbove #251
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
assertAbove()
function is incorrectly documented as a way to check for a minimum version and is actually a footgun if used in this way. (Ask me how I know... LOL)Instead, you must specify the version prior to the minimum version you are concerned about. This can also become an issue if there is a patch version of the prior version, which would then be unexpectedly accepted by the check. Ex: Ember Octane (v3.15) is the "true" minimum version, so you
assertAbove('3.14.2')
, but then v3.14.3 comes out...This PR clarifies the documentation for
assertAbove()
andisAbove()
but also addsassertAtOrAbove()
andisAtOrAbove()
, with documentation and testing. Basically the difference between the two isgt()
vsgte()
.