This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Pass console object that wraps this.ui #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes a
consoleobject in the options object passed to broccoli-lint-eslint (see ember-cli/broccoli-lint-eslint#51).This means that broccoli-lint-eslint can respect the
--silentoption by using this object over theconsoleglobal.I was able to test this in a project that uses
ember-cli-eslintby npm-linking ember-cli-eslint and broccoli-lint-eslint locally:This should be a non-breaking change, but we may want to co-ordinate this with a version bump in broccoli-lint-eslint.