Remove use of @ember/string to avoid ember-string.add-package deprecation
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
changed the title
@ember/string@ember/string to avoid deprecation
|
👍 I think this makes sense and is not a breaking change. |
kategengler
approved these changes
Jan 13, 2023
bertdeblock
changed the title
@ember/string to avoid deprecation@ember/string to avoid ember-string.add-package deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing from
@ember/stringin Ember v4.10, without having the@ember/stringaddon installed is deprecated.Normally, the current proposed solution would be to add
@ember/stringas a peer dependency and have the consuming app bring in the addon. However, in this case, I think we can just remove the use of@ember/stringall together. This will now log the app's name as is, untransformed.