Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useEmberModule option to force ember module usage (to avoid global window.Ember deprecation on Ember 3.27+). #175

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Add useEmberModule option to force ember module usage (to avoid global window.Ember deprecation on Ember 3.27+). #175

merged 2 commits into from
Feb 16, 2021

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli mentioned this pull request Feb 2, 2021
Closed
rwjblue
rwjblue requested changes Feb 2, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to add ember import when it replaces other imports.

Test case:

// input
import Component from '@ember/component';

export default class extends Component {}
// output
import Ember from 'ember';

export default class extends Ember.Component {}

rwjblue
rwjblue reviewed Feb 2, 2021
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
NullVoxPopuli and others added 2 commits February 15, 2021 13:29
@NullVoxPopuli @rwjblue
Add option to preserve import Ember from 'ember';
6e2f2f8
@rwjblue
Refactor to fix up a few issues.
61b457e 
* Ensure import is only added if needed
* Use `scope.generateUidIdentifier` to create the new local when needed
* Ensure the identifier rewriting code uses the correct identifier
@rwjblue rwjblue force-pushed the add-option-to-preserve-ember-import branch from 6408f46 to 61b457e Compare February 15, 2021 18:31
@rwjblue
Copy link
Member

rwjblue commented Feb 15, 2021

Fixed a few issues and updated (along with a rebase).

@rwjblue rwjblue merged commit 51a9b4b into ember-cli:master Feb 16, 2021
@rwjblue rwjblue changed the title Add option to preserve import Ember from 'ember'; Add option to force ember module usage (to avoid global window.Ember deprecation on Ember 3.27+). Feb 16, 2021
@rwjblue rwjblue changed the title Add option to force ember module usage (to avoid global window.Ember deprecation on Ember 3.27+). Add useEmberModule option to force ember module usage (to avoid global window.Ember deprecation on Ember 3.27+). Feb 16, 2021
@pzuraq pzuraq mentioned this pull request Feb 19, 2021
Merged
@NullVoxPopuli NullVoxPopuli mentioned this pull request Feb 22, 2021
Closed
This was referenced Mar 18, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @rwjblue