Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to outerHeight / outerWidth for explode / flyTo. #206

Closed

Conversation

green-arrow
Copy link

Addresses #205

@ef4
Copy link
Collaborator

ef4 commented Mar 30, 2015

Thanks for the PR.

This seems to correct some cases but not all. We're now measuring outerWidth but still setting width. This will appear to work correctly when using box-sizing: border-box, but it will cause a jump when using the default box-sizing.

ef4 added a commit that referenced this pull request Mar 31, 2015
@ef4
Copy link
Collaborator

ef4 commented Mar 31, 2015

The above commit fixes explode.

We still need an equivalent change in fly-to. That will be much easier to do if we can land this PR in Velocity: julianshapiro/velocity#485

@green-arrow
Copy link
Author

👍 on the Velocity PR. I would suggest waiting on that to make it through before tackling fly-to.

@ef4
Copy link
Collaborator

ef4 commented Apr 1, 2015

Closed via 8622f07

@ef4 ef4 closed this Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants