Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after upgrading to glimmer (canary) liquid fire breaks #276

Closed
mgenev opened this issue May 5, 2015 · 4 comments
Closed

after upgrading to glimmer (canary) liquid fire breaks #276

mgenev opened this issue May 5, 2015 · 4 comments

Comments

@mgenev
Copy link

mgenev commented May 5, 2015

I get these errors on my templates:

File: client/pods/components/album-picker/template.hbs
Cannot read property 'path' of undefined
TypeError: Cannot read property 'path' of undefined
    at TransformLiquidWithAsToHash.TransformWithAsToHash_validate [as validate] (/Users/martin.genev/Projects/how-to/client/node_modules/liquid-fire/ext/plugins/transform-liquid-with-as-to-hash.js:45:15)
    at /Users/martin.genev/Projects/how-to/client/node_modules/liquid-fire/ext/plugins/transform-liquid-with-as-to-hash.js:28:23
    at Walker.visit (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15274:7)
    at visitors.Program (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15284:16)
    at Walker.children (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15307:7)
    at Walker.visit (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15275:12)
    at TransformLiquidWithAsToHash.TransformWithAsToHash_transform [as transform] (/Users/martin.genev/Projects/how-to/client/node_modules/liquid-fire/ext/plugins/transform-liquid-with-as-to-hash.js:27:10)
    at Object.preprocess (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:14877:27)
    at compileSpec (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:10450:22)
    at TemplateCompiler.exports.default [as precompile] (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:10377:12)
@alexBaizeau
Copy link

Same here, in a pod as well

@ef4
Copy link
Collaborator

ef4 commented May 5, 2015

We are not glimmer compatible yet. That particular error is fixed on master
but there is still more to do.
On May 5, 2015 12:23 PM, "Martin Genev" [email protected] wrote:

I get these errors on my templates:

File: client/pods/components/album-picker/template.hbs
Cannot read property 'path' of undefined
TypeError: Cannot read property 'path' of undefined
at TransformLiquidWithAsToHash.TransformWithAsToHash_validate as validate
at /Users/martin.genev/Projects/how-to/client/node_modules/liquid-fire/ext/plugins/transform-liquid-with-as-to-hash.js:28:23
at Walker.visit (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15274:7)
at visitors.Program (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15284:16)
at Walker.children (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15307:7)
at Walker.visit (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:15275:12)
at TransformLiquidWithAsToHash.TransformWithAsToHash_transform as transform
at Object.preprocess (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:14877:27)
at compileSpec (/Users/martin.genev/Projects/how-to/client/bower_components/ember/ember-template-compiler.js:10450:22)
at TemplateCompiler.exports.default as precompile


Reply to this email directly or view it on GitHub
#276.

@davewasmer
Copy link
Contributor

It would seem that 0.20 is compatible now? Might be able to close this one out.

https://github.com/ef4/liquid-fire#ember-compatibility-table

@ef4
Copy link
Collaborator

ef4 commented May 18, 2015

Yes, people should test glimmer with liquid-fire 0.20.0.

@ef4 ef4 closed this as completed May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants