Update ember-qunit to latest beta. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some issues with apps/addons that do not have ember-auto-import themselves.
rwjblue
commented
Sep 16, 2020
| @@ -90,7 +90,6 @@ | |||
| "npm-run-all": "^4.1.5", | |||
| "prettier": "^2.0.5", | |||
| "qunit": "^2.11.0", | |||
| "qunit-dom": "^1.4.0", | |||
There was a problem hiding this comment.
qunit-dom is not compatible (yet, working on a PR) with the latest ember-qunit beta, and since we don't directly use it I figured I'd just remove it...
scalvert
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with apps/addons that do not have ember-auto-import themselves.