Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding omnis results on STS12 #58

Closed
wants to merge 4 commits into from

Conversation

perticarari
Copy link

Adding results of a test-embedding, which I titled omniembedding, on the STS12 dataset.

@perticarari
Copy link
Author

At first, I had some misunderstandings about how to include the revision_id, but it was all fixed in the last commit.

@KennethEnevoldsen
Copy link
Contributor

Hi @perticarari thanks for the PR :) We are working on a new version of the leaderboard (v2), which should give a better overview.

In that process, we are cleaning up the models, where users of the benchmark would not be able to interpret the results.

I believe this might be such a case. A user would be unable to use the model or figure out how it got the results, therefore it does not add a lot of information to the leaderboard.

Our decision has yet to be finalized so if you have strong points I would be more than happy to consider them - we want the benchmark to be as useable as possible

@perticarari
Copy link
Author

Hi, @KennethEnevoldsen

I didn't quite understand what the issue is. What should I add / remove to get this PR approved? Is it related to the model card or model description?

@x-tabdeveloping
Copy link

The canonically accepted way to do this would probably be to first implement your model along with detailed metadata in the mteb software package and then running your model that way.
Your PR is currently missing a lot of details including references to your model on HF Hub and model details.
We are also missing information on how you implemented your evaluations.
Please submit a PR to https://github.com/embeddings-benchmark/mteb including a model implementation along with metadata, then run your model with MTEB, then submit a PR here.

@KennethEnevoldsen
Copy link
Contributor

I will close this for now. Feel free to keep the discussion going, but currently it seems like this discussion has died out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants