Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use daemon property instead #6

Merged
merged 3 commits into from
Nov 1, 2022
Merged

use daemon property instead #6

merged 3 commits into from
Nov 1, 2022

Conversation

jupe
Copy link
Contributor

@jupe jupe commented Oct 17, 2022

silent deprecate warning:

/usr/local/lib/python3.10/site-packages/SnifferAPI/UART.py:143: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
[2428](https://github.com/jouzen/pyring/actions/runs/3250136578/jobs/5333400323#step:5:2565)
    self.worker_thread.setDaemon(True)

ref: python/cpython#25174

@jupe jupe requested a review from mkarhumaa October 17, 2022 08:59
@jupe jupe added the enhancement New feature or request label Oct 18, 2022
@jupe

This comment was marked as resolved.

Sign in to view
@jupe jupe merged commit db543cd into main Nov 1, 2022
@jupe jupe deleted the deprecate_update branch November 1, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarhumaa mkarhumaa mkarhumaa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jupe @mkarhumaa