Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip, signpost #1978

Conversation

elasticdotventures
Copy link

@elasticdotventures elasticdotventures commented Sep 30, 2023

this WIP will be a signpost & WIP that spans:
esp-rs/esp-hal#834
drogue-iot/drogue-device#388

@Dirbaio
Copy link
Member

Dirbaio commented Oct 1, 2023

IMO we shouldn't add esp32 examples to the Embassy repo. The esp-32 hal is maintained at https://github.com/esp-rs/esp-hal, that repo is much better positioned to host the examples since they can check in CI that they're always updated to the latest esp-hal version. If we add the examples here, they'll fall out of date unless we invest recurring effort in updating them. Out-of-date examples are confusing for the users, it's best to just point them to the esp-hal repo.

@lulf
Copy link
Member

lulf commented Oct 2, 2023

Agreed with @Dirbaio. I think a useful contribution would be to add references to the esp-hal embassy examples in the documentation

@barafael
Copy link
Contributor

barafael commented Jun 1, 2024

@Dirbaio looks like this can be closed?

@Dirbaio Dirbaio closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants