-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: testing differents prompts #26
Conversation
@@ -233,7 +264,7 @@ async function main() { | |||
|
|||
const comments = await analyzeCode(filteredDiff, prDetails); | |||
if (comments.length > 0) { | |||
await createReviewComment( | |||
createReviewOnPr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'await' keyword is missing before the 'createReviewOnPr' function call. It should be added to ensure that the function is awaited before proceeding.
08396fa
to
33fbab0
Compare
@@ -25,5 +25,4 @@ jobs: | |||
exclude: "**/*.json, **/*.md, **/*.g.dart" | |||
append_prompt: | | |||
- Give a maximum of 4 suggestions | |||
- Do not suggest code formatting issues. | |||
- Do not suggest imports issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the line with the comment 'Do not suggest imports issues.' since it is not needed anymore.
@@ -233,7 +264,7 @@ async function main() { | |||
|
|||
const comments = await analyzeCode(filteredDiff, prDetails); | |||
if (comments.length > 0) { | |||
await createReviewComment( | |||
createReviewOnPr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing 'await' keyword before 'createReviewOnPr' function call.
33fbab0
to
88bd9b9
Compare
@@ -25,5 +25,4 @@ jobs: | |||
exclude: "**/*.json, **/*.md, **/*.g.dart" | |||
append_prompt: | | |||
- Give a maximum of 4 suggestions | |||
- Do not suggest code formatting issues. | |||
- Do not suggest imports issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the line with the comment 'Do not suggest imports issues.'
@@ -233,7 +264,7 @@ async function main() { | |||
|
|||
const comments = await analyzeCode(filteredDiff, prDetails); | |||
if (comments.length > 0) { | |||
await createReviewComment( | |||
createReviewOnPr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing 'await' keyword before 'createReviewOnPr' function call.
No description provided.