Code review #16
Code review #16
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,29 @@ | |||
| name: Code Reviewer | |||
There was a problem hiding this comment.
The 'name' field should be a descriptive name for the workflow, not 'Code Reviewer'.
| @@ -0,0 +1,29 @@ | |||
| name: Code Reviewer | |||
| run-name: Action started by ${{ github.actor }} | |||
There was a problem hiding this comment.
The 'run-name' field is not a valid field in a workflow file.
| - opened | ||
| - synchronize | ||
|
|
||
| permissions: write-all |
There was a problem hiding this comment.
The 'permissions' field is not a valid field in a workflow file.
| openai_key: ${{ secrets.OPENAI_KEY }} | ||
| max_tokens: 900 | ||
| exclude: "**/*.json, **/*.md, **/*.g.dart" | ||
| append_prompt: | |
There was a problem hiding this comment.
The 'append_prompt' field should not have a '|' character at the end.
| for (const file of parsedDiff) { | ||
| if (file.to === "/dev/null") continue; // Ignore deleted files | ||
| for (const chunk of file.chunks) { | ||
|
|
There was a problem hiding this comment.
The variable 'messages' is not used in the loop. Consider removing it or using it in the loop.
|
|
||
| const prDetails = await getPRDetails(); | ||
| let diff; // string | null | ||
| const eventData = JSON.parse( |
There was a problem hiding this comment.
The variable 'diff' is declared but never used. Consider removing it.
| @@ -29,6 +29,18 @@ class SimpleChatGptService { | |||
| throw error; | |||
| } | |||
| } | |||
|
|
|||
| // chatCompletionParams: ChatCompletionParams | |||
There was a problem hiding this comment.
Consider adding a comment to describe the purpose of the 'fromParams' method.
| // chatCompletionParams: ChatCompletionParams | ||
| async fromParams({ chatCompletionParams }) { | ||
| try { | ||
| const response = await this.service.chatCompletions(chatCompletionParams); |
There was a problem hiding this comment.
Consider adding error handling for the case when 'response.choices' is empty.
| const message = response.choices[0].message.content; | ||
| return message; | ||
| } catch (error) { | ||
| console.error('[SimpleChatGptService]', error); |
There was a problem hiding this comment.
Avoid logging the error twice. Remove the console.error statement.
| console.error('[SimpleChatGptService]', error); | ||
| throw error; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| module.exports = SimpleChatGptService; |
There was a problem hiding this comment.
Remove the '\ No newline at end of file' line.
No description provided.