Code review #15

emanuel-braz · 2023-11-10T00:34:02Z

No description provided.

github-actions · 2023-11-10T00:34:42Z

.github/workflows/code-review.yaml

@@ -0,0 +1,29 @@
+name: Code Reviewer


The 'name' field is not necessary in this workflow. It can be removed.

github-actions · 2023-11-10T00:34:42Z

.github/workflows/code-review.yaml

@@ -0,0 +1,29 @@
+name: Code Reviewer
+run-name: Action started by ${{ github.actor }}


The 'run-name' field is not a valid field in a workflow. It should be removed.

github-actions · 2023-11-10T00:34:42Z

.github/workflows/code-review.yaml

+      - opened
+      - synchronize
+
+permissions: write-all


The 'permissions' field is not necessary in this workflow. It can be removed.

github-actions · 2023-11-10T00:34:42Z

.github/workflows/code-review.yaml

+          append_prompt: |
+            - Give a maximum of 4 suggestions
+            - Do not suggest code formatting issues.
+            - Do not suggest imports issues.


There is a missing newline at the end of the file. Please add a newline.

github-actions · 2023-11-10T00:34:42Z

code-review/action.js

@@ -0,0 +1,246 @@
+require('child_process')


Missing 'const' keyword before require statement.

github-actions · 2023-11-10T00:34:42Z

code-review/action.js

+const core = require('@actions/core');
+const github = require('@actions/github');
+const fs = require('fs');
+const SimpleChatGptService = require('../services/simple_chat_gpt_service.js');


Missing 'const' keyword before require statement.

github-actions · 2023-11-10T00:34:42Z

code-review/action.js

+const github = require('@actions/github');
+const fs = require('fs');
+const SimpleChatGptService = require('../services/simple_chat_gpt_service.js');
+const ChatCompletionParams = require('../services/gpt/chat_completion_params.js');


Missing 'const' keyword before require statement.

github-actions · 2023-11-10T00:34:43Z

services/simple_chat_gpt_service.js

@@ -29,6 +29,18 @@ class SimpleChatGptService {
      throw error;
    }
  }
+
+  // chatCompletionParams: ChatCompletionParams


Consider adding a comment to describe the purpose of this method.

github-actions · 2023-11-10T00:34:43Z

services/simple_chat_gpt_service.js

+  // chatCompletionParams: ChatCompletionParams
+  async fromParams({ chatCompletionParams }) {
+    try {
+      const response = await this.service.chatCompletions(chatCompletionParams);


Consider adding error handling for cases where response.choices is empty.

github-actions · 2023-11-10T00:34:43Z

services/simple_chat_gpt_service.js

+      console.error('[SimpleChatGptService]', error);
+      throw error;
+    }
+  }
 }

 module.exports = SimpleChatGptService;


Consider adding a newline at the end of the file.

github-actions · 2023-11-10T00:36:46Z

.github/workflows/code-review.yaml

+          max_tokens: 900
+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a maximum of 4 suggestions


The line number in the diff is incorrect. It should be line 28 instead of line 27.

github-actions · 2023-11-10T00:36:46Z

.github/workflows/code-review.yaml

+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a maximum of 4 suggestions
+            - Do not suggest code formatting issues.


The comment in the 'append_prompt' should be updated to reflect the correct number of suggestions.

github-actions · 2023-11-10T00:36:47Z

.github/workflows/code-review.yaml

+          append_prompt: |
+            - Give a maximum of 4 suggestions
+            - Do not suggest code formatting issues.
+            - Do not suggest imports issues.


The comment in the 'append_prompt' should be updated to reflect the correct restrictions on code formatting issues.

github-actions · 2023-11-10T00:36:47Z

.github/workflows/code-review.yaml

+          append_prompt: |
+            - Give a maximum of 4 suggestions
+            - Do not suggest code formatting issues.
+            - Do not suggest imports issues.


The comment in the 'append_prompt' should be updated to reflect the correct restrictions on imports issues.

github-actions · 2023-11-10T00:36:47Z

code-review/action.js

+    for (const file of parsedDiff) {
+        if (file.to === "/dev/null") continue; // Ignore deleted files
+        for (const chunk of file.chunks) {
+            logger.log(`Analyzing chunk: ${chunk.changes}\n------------------`);


The log message should be more descriptive and provide useful information about the chunk being analyzed.

github-actions · 2023-11-10T00:36:47Z

code-review/action.js

+}
+
+function createMessages(file, chunk, prDetails) {
+    const instructionJsonFormat = `- Always provide the response in following JSON format:  [{"lineNumber":  <line_number>, "reviewComment": "<review comment>"}]`;


The variable 'instructionJsonFormat' is defined but not used.

github-actions · 2023-11-10T00:36:47Z

code-review/action.js

+function createMessages(file, chunk, prDetails) {
+    const instructionJsonFormat = `- Always provide the response in following JSON format:  [{"lineNumber":  <line_number>, "reviewComment": "<review comment>"}]`;
+
+    var contentSystemMessage = `You are a senior software engineer and your task is to review pull requests for possible bugs or bad development practices. Follow the instructions below:


The variable 'contentSystemMessage' is defined but not used.

github-actions · 2023-11-10T00:36:47Z

code-review/action.js

+
+    var contentSystemMessage = `You are a senior software engineer and your task is to review pull requests for possible bugs or bad development practices. Follow the instructions below:
+- You will provide suggestions only if there is possible issues or bugs in the code, otherwise return an empty array.
+- Do not give positive comments or compliments.


The '+' sign is not needed here.

github-actions · 2023-11-10T00:36:47Z

code-review/action.js

+    var contentSystemMessage = `You are a senior software engineer and your task is to review pull requests for possible bugs or bad development practices. Follow the instructions below:
+- You will provide suggestions only if there is possible issues or bugs in the code, otherwise return an empty array.
+- Do not give positive comments or compliments.
+- Don't suggest removing empty line or adding line to end of file


The '-' sign is not needed here.

github-actions · 2023-11-10T00:43:47Z

.github/workflows/code-review.yaml

+          max_tokens: 900
+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a maximum of 4 suggestions


The line number in the diff is incorrect. It should be line 28 instead of line 27.

github-actions · 2023-11-10T00:43:47Z

.github/workflows/code-review.yaml

+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a maximum of 4 suggestions
+            - Do not suggest code formatting issues.


The comment in the 'append_prompt' should be updated to reflect the correct number of suggestions.

github-actions · 2023-11-10T00:43:47Z

.github/workflows/code-review.yaml

+          append_prompt: |
+            - Give a maximum of 4 suggestions
+            - Do not suggest code formatting issues.
+            - Do not suggest imports issues.


The comment in the 'append_prompt' should be updated to reflect the correct instructions about code formatting issues.

github-actions · 2023-11-10T00:43:47Z

.github/workflows/code-review.yaml

+          append_prompt: |
+            - Give a maximum of 4 suggestions
+            - Do not suggest code formatting issues.
+            - Do not suggest imports issues.


The comment in the 'append_prompt' should be updated to reflect the correct instructions about imports issues.

github-actions · 2023-11-10T00:43:47Z

code-review/action.js

+    for (const file of parsedDiff) {
+        if (file.to === "/dev/null") continue; // Ignore deleted files
+        for (const chunk of file.chunks) {
+


There is an extra empty line at line 65.

github-actions · 2023-11-10T00:43:47Z

code-review/action.js

+}
+
+function createMessages(file, chunk, prDetails) {
+    const instructionJsonFormat = `- Always provide the response in following JSON format:  [{"lineNumber":  <line_number>, "reviewComment": "<review comment>"}]`;


The variable instructionJsonFormat is defined but not used.

github-actions · 2023-11-10T00:43:47Z

code-review/action.js

+function createMessages(file, chunk, prDetails) {
+    const instructionJsonFormat = `- Always provide the response in following JSON format:  [{"lineNumber":  <line_number>, "reviewComment": "<review comment>"}]`;
+
+    var contentSystemMessage = `You are a senior software engineer and your task is to review pull requests for possible bugs or bad development practices. Follow the instructions below:


The variable contentSystemMessage is defined but not used.

github-actions · 2023-11-10T00:43:47Z

code-review/action.js

+
+    var contentSystemMessage = `You are a senior software engineer and your task is to review pull requests for possible bugs or bad development practices. Follow the instructions below:
+- You will provide suggestions only if there is possible issues or bugs in the code, otherwise return an empty array.
+- Do not give positive comments or compliments.


The instruction 'Do not give positive comments or compliments.' is duplicated.

github-actions · 2023-11-10T00:43:47Z

code-review/action.js

+    var contentSystemMessage = `You are a senior software engineer and your task is to review pull requests for possible bugs or bad development practices. Follow the instructions below:
+- You will provide suggestions only if there is possible issues or bugs in the code, otherwise return an empty array.
+- Do not give positive comments or compliments.
+- Don't suggest removing empty line or adding line to end of file.


The instruction 'Don't suggest removing empty line or adding line to end of file.' is duplicated.

emanuel-braz added 5 commits November 8, 2023 01:19

feat: add code review functionality

fbe8236

feat: prompt improvements

99824af

feat: reduce temperature

078c2a3

chore: using portuguese to sugestions

4ea08b5

feat: add max_tokens params

f7e89f5

github-actions bot reviewed Nov 10, 2023

View reviewed changes

emanuel-braz force-pushed the code-review branch from ed02d9e to f89bfdd Compare November 10, 2023 00:36

github-actions bot reviewed Nov 10, 2023

View reviewed changes

emanuel-braz force-pushed the code-review branch 2 times, most recently from b27bb48 to 48b859f Compare November 10, 2023 00:43

github-actions bot reviewed Nov 10, 2023

View reviewed changes

feat: testing different prompts

9df47c2

emanuel-braz force-pushed the code-review branch from 48b859f to 9df47c2 Compare November 10, 2023 00:49

emanuel-braz closed this Nov 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code review #15

Code review #15

emanuel-braz commented Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

github-actions bot Nov 10, 2023

		@@ -0,0 +1,29 @@
		name: Code Reviewer
		run-name: Action started by ${{ github.actor }}

Code review #15

Code review #15

Conversation

emanuel-braz commented Nov 10, 2023

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment

github-actions bot Nov 10, 2023

Choose a reason for hiding this comment