Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #13

Closed
wants to merge 6 commits into from
Closed

Code review #13

wants to merge 6 commits into from

Conversation

emanuel-braz
Copy link
Owner

No description provided.

@@ -0,0 +1,29 @@
name: Code Reviewer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O nome do fluxo de trabalho deve ser mais descritivo.

@@ -0,0 +1,29 @@
name: Code Reviewer
run-name: Action started by ${{ github.actor }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O nome do trabalho em execução deve ser mais descritivo.

- opened
- synchronize

permissions: write-all
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As permissões 'write-all' são muito amplas. Considere restringir as permissões necessárias.

- name: Checkout Repo
uses: actions/checkout@v4

- name: Code Review the pull request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O nome da etapa deve ser mais descritivo.

openai_key: ${{ secrets.OPENAI_KEY }}
max_tokens: 900
exclude: "**/*.json, **/*.md, **/*.g.dart"
append_prompt: |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A prompt de anexação deve ser mais clara e concisa.

description: "The text to be used to override the default prompt."
required: false
append_prompt:
description: "The text to be used to append to the default prompt."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A entrada 'append_prompt' deve ter uma descrição.

required: false

runs:
using: "node16"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A propriedade 'runs' está faltando.

@@ -29,6 +29,18 @@ class SimpleChatGptService {
throw error;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remova a linha vazia desnecessária.

@@ -29,6 +29,18 @@ class SimpleChatGptService {
throw error;
}
}

// chatCompletionParams: ChatCompletionParams
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicione um comentário explicando o propósito deste método.

console.error('[SimpleChatGptService]', error);
throw error;
}
}
}

module.exports = SimpleChatGptService;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicione uma nova linha no final do arquivo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant