Code review #12

emanuel-braz · 2023-11-08T22:07:58Z

No description provided.

github-actions · 2023-11-08T22:08:46Z

.github/workflows/code-review.yaml

@@ -0,0 +1,26 @@
+name: Code Reviewer


O nome do fluxo de trabalho não está claro. Deve ser mais descritivo.

github-actions · 2023-11-08T22:08:46Z

.github/workflows/code-review.yaml

@@ -0,0 +1,26 @@
+name: Code Reviewer
+run-name: Action started by ${{ github.actor }}


O nome do trabalho em execução não está claro. Deve ser mais descritivo.

github-actions · 2023-11-08T22:08:46Z

.github/workflows/code-review.yaml

+name: Code Reviewer
+run-name: Action started by ${{ github.actor }}
+
+on:


O evento 'pull_request' não está configurado corretamente. Verifique a sintaxe.

github-actions · 2023-11-08T22:08:46Z

.github/workflows/code-review.yaml

+      - opened
+      - synchronize
+
+permissions: write-all


As permissões 'write-all' são muito amplas. Considere restringir as permissões necessárias.

github-actions · 2023-11-08T22:08:46Z

.github/workflows/code-review.yaml

+      - name: Checkout Repo
+        uses: actions/checkout@v4
+
+      - name: Code Review the pull request


O nome da etapa não está claro. Deve ser mais descritivo.

github-actions · 2023-11-08T22:08:49Z

code-review/action.yml

+    description: "The text to be used to append to the default prompt."
+    required: false
+
+runs:


Adicione um comentário explicando o propósito desta propriedade.

github-actions · 2023-11-08T22:08:49Z

code-review/action.yml

+    required: false
+
+runs:
+  using: "node16"


Adicione um comentário explicando o propósito desta propriedade.

github-actions · 2023-11-08T22:08:49Z

services/simple_chat_gpt_service.js

@@ -29,6 +29,18 @@ class SimpleChatGptService {
      throw error;


Remova a linha vazia desnecessária.

github-actions · 2023-11-08T22:08:50Z

services/simple_chat_gpt_service.js

@@ -29,6 +29,18 @@ class SimpleChatGptService {
      throw error;
    }
  }
+
+  // chatCompletionParams: ChatCompletionParams


Adicione um comentário explicando o propósito deste método.

github-actions · 2023-11-08T22:08:50Z

services/simple_chat_gpt_service.js

+      console.error('[SimpleChatGptService]', error);
+      throw error;
+    }
+  }
 }

 module.exports = SimpleChatGptService;


Adicione uma nova linha ao final do arquivo.

github-actions · 2023-11-08T22:20:30Z

.github/workflows/code-review.yaml

+
+      - name: Code Review the pull request
+        uses: ./code-review
+        with:


Adicionar um espaço em branco após a vírgula.

github-actions · 2023-11-08T22:20:30Z

.github/workflows/code-review.yaml

+          max_tokens: 900
+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a minimum of 0 suggestions and a maximum of 5 suggestions.


Remover o espaço em branco antes do sinal de adição.

github-actions · 2023-11-08T22:20:30Z

.github/workflows/code-review.yaml

+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a minimum of 0 suggestions and a maximum of 5 suggestions.
+            - Translate the comment in all "reviewComment" properties to portuguese (pt-br).


Adicionar uma nova linha no final do arquivo.

github-actions · 2023-11-08T22:20:30Z

code-review/action.js

+const logger = new Logger(true, core);
+const GITHUB_TOKEN = core.getInput("token");
+const OPENAI_API_KEY = core.getInput("openai_key");
+const OPENAI_API_MODEL = core.getInput("openai_key_model");


Verifique se a variável 'maxTokens' está sendo utilizada corretamente.

github-actions · 2023-11-08T22:20:30Z

code-review/action.js

+const overridePrompt = core.getInput("override_prompt");
+const appendPrompt = core.getInput("append_prompt");
+const maxTokens = core.getInput("max_tokens");
+const excludePatterns = core


Verifique se a variável 'excludePatterns' está sendo utilizada corretamente.

github-actions · 2023-11-08T22:20:30Z

code-review/action.js

+
+async function getAIResponse(messages) {
+
+    logger.log(`Max tokens: ${maxTokens}`);


Adicione um espaço antes do parêntese de abertura.

github-actions · 2023-11-08T22:20:30Z

code-review/action.js

+
+    try {
+        const chatCompletionParams = new ChatCompletionParams({
+            messages: messages,


Remova o espaço antes do sinal de igual.

github-actions · 2023-11-08T22:20:31Z

code-review/action.js

+            messages: messages,
+            model: OPENAI_API_MODEL,
+            temperature: 0,
+            max_tokens: parseInt(maxTokens),


Adicione um espaço antes do sinal de igual.

github-actions · 2023-11-08T22:20:31Z

code-review/action.yml

+    description: "OpenAI API model."
+    required: false
+    default: "gpt-3.5-turbo"
+  max_tokens:


A propriedade 'max_tokens' não está indentada corretamente. Deve estar alinhada com as outras propriedades.

github-actions · 2023-11-08T22:20:31Z

code-review/action.yml

+    default: "gpt-3.5-turbo"
+  max_tokens:
+    description: "OpenAI API max tokens."
+    default: "900"


A propriedade 'default' não está indentada corretamente. Deve estar alinhada com as outras propriedades.

github-actions · 2023-11-08T22:41:51Z

.github/workflows/code-review.yaml

+
+      - name: Code Review the pull request
+        uses: ./code-review
+        with:


Adicionar um espaço em branco antes do sinal de igual.

github-actions · 2023-11-08T22:41:51Z

.github/workflows/code-review.yaml

+          max_tokens: 900
+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a minimum of 0 suggestions and a maximum of 5 suggestions.


Remover o espaço em branco antes do sinal de adição.

github-actions · 2023-11-08T22:41:51Z

.github/workflows/code-review.yaml

+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a minimum of 0 suggestions and a maximum of 5 suggestions.
+            - Translate the comment in all "reviewComment" properties to portuguese (pt-br).


Adicionar uma nova linha no final do arquivo.

github-actions · 2023-11-08T22:41:51Z

.github/workflows/code-review.yaml

+          exclude: "**/*.json, **/*.md, **/*.g.dart"
+          append_prompt: |
+            - Give a minimum of 0 suggestions and a maximum of 5 suggestions.
+            - Translate the comment in all "reviewComment" properties to portuguese (pt-br).


Remover a linha vazia no final do arquivo.

github-actions · 2023-11-08T22:41:51Z

.github/workflows/code-review.yaml

+          token: ${{ secrets.GITHUB_TOKEN }}
+          openai_key: ${{ secrets.OPENAI_KEY }}
+          max_tokens: 900
+          exclude: "**/*.json, **/*.md, **/*.g.dart"


Adicionar um espaço em branco antes do sinal de adição.

github-actions · 2023-11-08T22:41:51Z

code-review/action.js

+
+async function getAIResponse(messages) {
+
+    logger.log(`Max tokens: ${maxTokens}`);


Adicione um espaço antes do parêntese de abertura.

github-actions · 2023-11-08T22:41:52Z

code-review/action.js

+
+    try {
+        const chatCompletionParams = new ChatCompletionParams({
+            messages: messages,


Remova o espaço antes do sinal de igual.

github-actions · 2023-11-08T22:41:52Z

code-review/action.js

+            messages: messages,
+            model: OPENAI_API_MODEL,
+            temperature: 0,
+            max_tokens: parseInt(maxTokens),


Adicione um espaço antes do sinal de igual.

github-actions · 2023-11-08T22:41:52Z

code-review/action.yml

+    description: "OpenAI API model."
+    required: false
+    default: "gpt-3.5-turbo"
+  max_tokens:


A propriedade 'max_tokens' não está indentada corretamente. Deve estar alinhada com as outras propriedades.

github-actions · 2023-11-08T22:41:52Z

code-review/action.yml

+    default: "gpt-3.5-turbo"
+  max_tokens:
+    description: "OpenAI API max tokens."
+    default: "900"


A propriedade 'default' não está indentada corretamente. Deve estar alinhada com as outras propriedades.

emanuel-braz added 4 commits November 8, 2023 01:19

feat: add code review functionality

fbe8236

feat: prompt improvements

99824af

feat: reduce temperature

078c2a3

chore: using portuguese to sugestions

4ea08b5

github-actions bot reviewed Nov 8, 2023

View reviewed changes

feat: add max_tokens params

f7e89f5

emanuel-braz force-pushed the code-review branch from 28f6c09 to f7e89f5 Compare November 8, 2023 22:41

github-actions bot reviewed Nov 8, 2023

View reviewed changes

emanuel-braz closed this Nov 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code review #12

Code review #12

emanuel-braz commented Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

github-actions bot Nov 8, 2023

		@@ -0,0 +1,26 @@
		name: Code Reviewer
		run-name: Action started by ${{ github.actor }}


		async function getAIResponse(messages) {

		logger.log(`Max tokens: ${maxTokens}`);

Code review #12

Code review #12

Conversation

emanuel-braz commented Nov 8, 2023

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment

github-actions bot Nov 8, 2023

Choose a reason for hiding this comment