-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review #11
Code review #11
Conversation
@@ -0,0 +1,27 @@ | |||
name: Code Reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O nome do fluxo de trabalho não está claro. Considere renomeá-lo para algo mais descritivo.
@@ -0,0 +1,27 @@ | |||
name: Code Reviewer | |||
run-name: Action started by ${{ github.actor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O nome do trabalho não está claro. Considere renomeá-lo para algo mais descritivo.
- opened | ||
- synchronize | ||
|
||
permissions: write-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As permissões 'write-all' são muito amplas. Considere restringir as permissões necessárias para este trabalho.
@@ -0,0 +1,243 @@ | |||
require('child_process') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importação desnecessária: 'child_process'.
@@ -0,0 +1,243 @@ | |||
require('child_process') | |||
.execSync( | |||
'npm install @actions/core @actions/github parse-diff minimatch fs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comando 'npm install' sendo executado de forma síncrona.
name: emanuel-braz/code-review | ||
description: "Perform code reviews and comment on diffs using OpenAI API." | ||
author: Emanuel Braz | ||
branding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A propriedade 'branding' não é necessária para o funcionamento do código.
description: "OpenAI API model." | ||
required: false | ||
default: "gpt-3.5-turbo" | ||
exclude: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A propriedade 'exclude' não é necessária para o funcionamento do código.
@@ -29,6 +29,18 @@ class SimpleChatGptService { | |||
throw error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remova a linha vazia.
@@ -29,6 +29,18 @@ class SimpleChatGptService { | |||
throw error; | |||
} | |||
} | |||
|
|||
// chatCompletionParams: ChatCompletionParams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adicione um comentário descrevendo a função 'fromParams'.
console.error('[SimpleChatGptService]', error); | ||
throw error; | ||
} | ||
} | ||
} | ||
|
||
module.exports = SimpleChatGptService; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adicione uma nova linha no final do arquivo.
No description provided.