-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(queries): Update Zig highlights scm #688
Conversation
@jcs090218 can you look at this pr? Zig current highlights don't work with the new versions of the language. Also this may also close #624 EDIT: I also tried to update to the new upstream version https://github.com/tree-sitter-grammars/tree-sitter-zig with the updated highlights from neovim but i couldn't manage to compile it correctly. Kept getting ABI version mismatch for some reason and |
Can you try to see if it works on your side? I'm pretty sure I got it from the nvim repo a while ago. 🤔 |
I'm not too sure what do you mean, but I can confirm that the highlights in my commit do work. They are not the best though. The old ones don't. Some keywords are not being highlighted If you want I can retry with the new upstream repo so this pr kill two birds with one stone, but I'm not sure on how to resolve the issues I'm having |
Sorry for the late reply! I have been really busy recently! I got the queries from the nvim repo, but there were errors so we couldn't use it directly. 🤔
If the CI passed, then it should be good! 👍 You can try to compile it locally or open a PR with the updated upstream! |
19ca254
to
5129489
Compare
@jcs090218 I had to fight a bit with git submodules but in theory the CI should pass, I enabled it in my fork and it ran without any problems. This has the new repo and new-er highlights than the one from before. Although I didn't manage to test it on my machine since I kept getting the same problem of ABI incompatibility. |
Don't run the CI again because I think I saw some of the tests failing and not just because of gpr. Somehow on macos it failed on everything. EDIT: also when it's ready I will squash the commits if you need it |
Just let me know if you need a re-run! :) |
Ok my CI worked, so it should be all good I hope. |
Thank you for your hard work! 🚀 |
Got these from nvim-treesitter