-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tree-sitter-swift #118
Update tree-sitter-swift #118
Conversation
Looks like this is failing on this test |
Those tests are failing because the grammar only supports emojis when compiled using tree-sitter version 0.20.5 or newer. I recall from previous discussions that |
I'm pretty new with all things tree-sitter, so any advise from you how to best resolve the situation? E.g. wait for emacs-tree-sitter to update the dependency before considering to merge this? |
Conversely, I'm pretty new to how the Apart from not supporting emojis, the grammar behaves totally fine against older tree-sitter versions; there should be no issues merging this if there's some way to ignore those specific tests. It would still be a big improvement over what users are getting out-of-the-box today. If it's not possible to ignore specific tests, I wonder if you could skip all of them; I run tests on every commit in CI and I still test highlight queries against 0.19.0, so the chance of breakage seems quite low. This would also be a good reason to upgrade to a newer tree-sitter version, but I don't know what that entails :) |
I've been using it for few weeks and it works great. @alex-pinkus added some more keywords for highligtning. To get them themable we need to define them:
I don't know where they belong, I've written my own "swift-mode" extensions that loads them the first time I enter a swift-buffer (along with setup of LSP (eglot). The foreground color is just a dummy though. |
We should probably update the tree-sitter version used in the CI. It requires a bit of rework of our test script. Let me see if I can get to that soon ish :D. |
Can you rebase this so the CI can test it? Thanks! |
9773482
to
c46944a
Compare
@jcs090218 Done. Updates the submodule HEAD as well |
Thank you! |
The https://github.com/tree-sitter/tree-sitter-swift repository's README says the repo is abandoned and one should use https://github.com/alex-pinkus/tree-sitter-swift instead.
This PR changes the repository reference to match.
script/compile
andscript/test
is working 👍Edit: Noticed the issue; fixes #72