Skip to content
This repository has been archived by the owner on May 2, 2018. It is now read-only.

support ~ for php-auto-yasnippet-php-program #14

Closed
drzraf opened this issue Feb 3, 2014 · 4 comments
Closed

support ~ for php-auto-yasnippet-php-program #14

drzraf opened this issue Feb 3, 2014 · 4 comments

Comments

@drzraf
Copy link

drzraf commented Feb 3, 2014

As of 2.1.0 and using php-mode 2.12 the variable php-auto-yasnippet-php-program does not seem expanded (the ~ [tidla] isn't replaced by $HOME).
That brings spurious "Cannot run the program ~/.emacs.d/php/Create-PHP-YASnippet.php"

@ejmr
Copy link
Collaborator

ejmr commented Feb 3, 2014

Thank you for the bug report. I'm guessing this is a problem in the payas/create-template function; it would either expand the tilde to $HOME or maybe it's a problem with not using call-process correctly. I will look into this soon.

@amcorreia
Copy link

@drzraf see if my patch work for you too.

@drzraf
Copy link
Author

drzraf commented Mar 24, 2014

yes, this fixes this specific problem ! thx

(but still, I'm not using php-auto-yasnippets since it does not work for me, issue #1 or maybe issue #15)
(PHP mode 1.12 from https://github.com/ejmr/php-mode may be the cause ?)

@ejmr ejmr closed this as completed in 1811766 Mar 28, 2014
ejmr pushed a commit that referenced this issue Mar 28, 2014
* github/pr/18:
  Add Alessandro Madruga Correia to the list of contributors
  This fixes #14. Tilde expansion.
@ejmr
Copy link
Collaborator

ejmr commented Mar 28, 2014

Thank you @amcorrela for the patch, and my apologies about it taking five days before I was able to merge and push it. Thanks @drzraf for reporting that the patch at least fixes this specific problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants