Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parent window margins from being used in UI doc child frame. #773

Merged
merged 1 commit into from
Apr 21, 2024

Commits on Apr 20, 2024

  1. Prevent parent window margins from being used in UI doc child frame.

    When margins are used in the main window (such as Flymake/Flycheck
    diagnostic indicators in the margin instead of the fringe), causing
    `left-margin-width` and/or `right-margin-width` in the parent to be
    non-zero, the child frame was seeing those margins and text was being
    wrapped incorrectly.
    
    The child frame is sized to handle the amount of text on a line (up to
    `lsp-ui-doc-max-width`) and then `fill-region` is used to hard-wrap
    the text.  The computation of the size of the frame assumes there are
    no fringes or margins which consume part of this frame.  However, when
    the margin was visible in the child frame, it was causing text to be
    soft-wrapped prior to the hard-wrap.
    
    This change sets the margin sizes to 0 in the buffer of the child
    frame and then forces the window of the child frame to utilize these
    settings, preventing parent margins from being displayed in the child
    frame.
    brownts committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    6f13df6 View commit details
    Browse the repository at this point in the history