-
-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding async-request-handlers for lsp-json
#1245
Conversation
6e05b97
to
a32f31e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You may fix lsp-json.el header as well.
a32f31e
to
cf5e8f8
Compare
I had some troubles when testing on clean machine with emacs 27.
|
Are you talking about
Oh, it works great on Windows though. |
I don't know - I am compiling it from source - Another option is to use lsp-docker, which has emacs 27.
I fixed these locally but I am unable to get completion working.
In general, I prefer having #506 in before working on any automatic installations because it makes the task harder(e. g. whoever starts working on it will have to fix all automatic installations that are implemented). If you insist keep it for windows. |
Can you post the locally fix here? I don't have emacs27 with native json now, so it would be better to reuse your fix.
The latest |
yyoncho@162c1d3
Can you document that? |
cf5e8f8
to
f9d4599
Compare
Fixed!!! |
Thank you! As a side note, when you mark a server with |
Oh, I didn't know about this. Certainly |
* lsp-json: adding async-request-handlers and public schemas url * Document vscode-json-languageserver broken
Since json language server requests emacs to provide file/remote resource content that may take time to retrieve, we need to make the request response being able to not block typing via async callback,
This is per discussion in #1073