Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A handy utility for updating fsac #1112

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Conversation

Gastove
Copy link
Contributor

@Gastove Gastove commented Oct 18, 2019

A tiny commit to add a tiny function to make it easier to update FSharpAutoComplete. Handles the two-step of delete-old-dir, reinstall.

It's nice to be able to update before you start the server in question.
@yyoncho
Copy link
Member

yyoncho commented Oct 18, 2019

Not something to address in this PR but long term we should make it generic across language servers. For example, we may add another field in lsp--client - download-function and then we can create a generic function - lsp-update-server which will look for all language servers that have that field specified and it will ask the user to select one. This is related to #506

@Gastove
Copy link
Contributor Author

Gastove commented Oct 18, 2019

@yyoncho I really like this idea. Agreed, not for this PR, but having a language-agnostic mechanism for this would be delightful.

@TOTBWF
Copy link
Collaborator

TOTBWF commented Oct 18, 2019

Just tested this out and it LGTM!

@TOTBWF TOTBWF merged commit 51caba8 into emacs-lsp:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants