fix(lint/useImportType): jsxRuntime wasn't respected in combined im…

…port statement (biomejs#2483)

CHANGELOG.md

@@ -31,6 +31,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 #### Bug fixes
 
+- Fix case where `jsxRuntime` wasn't being respected by `useImportType` rule ([#2473](https://github.com/biomejs/biome/issues/2473)).Contributed by @arendjr
+
 ### Parser
 
 

crates/biome_js_analyze/src/lint/style/use_import_type.rs

@@ -126,7 +126,13 @@ impl Rule for UseImportType {
             AnyJsImportClause::JsImportCombinedClause(clause) => {
                 let default_binding = clause.default_specifier().ok()?.local_name().ok()?;
                 let default_binding = default_binding.as_js_identifier_binding()?;
-                let is_default_used_as_type = is_only_used_as_type(model, default_binding);
+                let is_default_used_as_type = if ctx.jsx_runtime() == JsxRuntime::ReactClassic
+                    && is_global_react_import(default_binding, ReactLibrary::React)
+                {
+                    false
+                } else {
+                    is_only_used_as_type(model, default_binding)
+                };
                 match clause.specifier().ok()? {
                     AnyJsCombinedSpecifier::JsNamedImportSpecifiers(named_specifiers) => {
                         match named_import_type_fix(model, &named_specifiers) {

crates/biome_js_analyze/tests/specs/style/useImportType/valid-unused-react-combined.options.json

@@ -0,0 +1,12 @@
+{
+    "linter": {
+        "rules": {
+            "style": {
+                "useImportType": "error"
+            }
+        }
+    },
+    "javascript": {
+        "jsxRuntime": "reactClassic"
+    }
+}

crates/biome_js_analyze/tests/specs/style/useImportType/valid-unused-react-combined.tsx

@@ -0,0 +1,8 @@
+import React, { MouseEvent } from 'react';
+
+function Component() {
+    const onClick = (event: MouseEvent) => { };
+    const onDblClick = (event: React.MouseEvent) => { };
+
+    return <div onClick={onClick} onDblClick={onDblClick}></div>;
+}

crates/biome_js_analyze/tests/specs/style/useImportType/valid-unused-react-combined.tsx.snap

@@ -0,0 +1,43 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid-unused-react-combined.tsx
+---
+# Input
+```tsx
+import React, { MouseEvent } from 'react';
+
+function Component() {
+    const onClick = (event: MouseEvent) => { };
+    const onDblClick = (event: React.MouseEvent) => { };
+
+    return <div onClick={onClick} onDblClick={onDblClick}></div>;
+}
+
+```
+
+# Diagnostics
+```
+valid-unused-react-combined.tsx:1:1 lint/style/useImportType  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Some named imports are only used as types.
+  
+  > 1 │ import React, { MouseEvent } from 'react';
+      │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    2 │ 
+    3 │ function Component() {
+  
+  i This import is only used as a type.
+  
+  > 1 │ import React, { MouseEvent } from 'react';
+      │                 ^^^^^^^^^^
+    2 │ 
+    3 │ function Component() {
+  
+  i Importing the types with import type ensures that they are removed by the transpilers and avoids loading unnecessary modules.
+  
+  i Safe fix: Use import type.
+  
+    1 │ import·React,·{·type·MouseEvent·}·from·'react';
+      │                 +++++                          
+
+```

website/src/content/docs/internals/changelog.md

@@ -37,6 +37,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 #### Bug fixes
 
+- Fix case where `jsxRuntime` wasn't being respected by `useImportType` rule ([#2473](https://github.com/biomejs/biome/issues/2473)).Contributed by @arendjr
+
 ### Parser