When to go 1.0 and what edition should 1.0 target?

[jacobrosenthal]

The generated source in master at the moment needs nightly because the gen script is currently enabling nightly to svd2rust.

error[E0554]: #![feature] may not be used on the stable release channel         
 --> /Users/jacobrosenthal/.cargo/git/checkouts/efm32-rs-8afe14a491208763/e359ec3/src/lib.rs:6:1
  |                                                                             
6 | #![feature(untagged_unions)]                                                
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                
                                                                                
error: aborting due to previous error                                           

Seems like were a ways out on that feature rust-lang/rust#32836

Im thinking 1.0 published should probably target stable. If you agree Ill change that.

Also cargo gen needs nightly, I think from rustfmt, but I dont think that matters. Ill document it in the readme though.

error[E0554]: #![feature] may not be used on the stable release channel                                        
   --> /Users/jacobrosenthal/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-graphviz-306.0.0/lib.rs:289:1
    |                                                                                                          
289 | #![feature(rustc_private, nll)]                                                                          
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                          
                                                                                                               
error[E0554]: #![feature] may not be used on the stable release channel                                        
   --> /Users/jacobrosenthal/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-graphviz-306.0.0/lib.rs:290:1
    |                                                                                                          
290 | #![feature(str_escape)]                                                                                  
    | ^^^^^^^^^^^^^^^^^^^^^^^                                                                                  
                                                                                                               
error: aborting due to 2 previous errors                                                                       

[fudanchii]

Right, kind of forgot I also overrides into nightly here.

I don't have any strong preference for stable though, so if it should be nightly we can mention it in the readme. As far as I checked the only addition for nightly is untagged_union directive. So I guess we can go stable just by dropping this.

[jacobrosenthal]

Yeah.. Honestly I can almost guarantee theyre going to be doing good svd2rust work soon and Ill bet it has more nightly stuff, but I figure lets get one release out there for stable folks?

[jacobrosenthal]

3:33 PM J<•japaric> Jacob_____: you should not relase 1.0 until all your crate dependencies are also 1.0. The reason is that if you ever need to bump the minor version of a dep then you may be forced (e.g. due to re-exports) to do a new major release of your crate
3:33 PM (of course, unless you are fine making several major releases of your crate)
3:37 PM J<Jacob_____> Jacob Rosenthal @japaric thanks. Thoughts on how to offer nightly and stable?
3:38 PM for PAC which doesnt offer a way to feature flag as far as I know
3:38 PM maybe svd2rust nightly boolean should take a feature flag name
3:41 PM J<•japaric> Jacob_____: imo, svd2rust should not even have a nightly flag. the overlapping register stuff can be handled without unions (nightly); it just hasn't been implemented. see rust-embedded/svd2rust#218