Dev 2015 cancel spot orders #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
+ Coverage 43.03% 43.08% +0.05%
==========================================
Files 681 682 +1
Lines 23494 23538 +44
==========================================
+ Hits 10111 10142 +31
- Misses 12162 12167 +5
- Partials 1221 1229 +8 |
cosmic-vagabond
requested changes
Oct 7, 2024
cosmic-vagabond
requested changes
Oct 10, 2024
cosmic-vagabond
requested changes
Oct 10, 2024
| return sdk.NewEvent(TypeEvtCloseSpotOrder, | ||
| sdk.NewAttribute("order_type", order.OrderType.String()), | ||
| sdk.NewAttribute("owner_address", order.OwnerAddress), | ||
| sdk.NewAttribute("id", strconv.FormatInt(int64(order.OrderId), 10)), |
There was a problem hiding this comment.
@cryptokage1996 we need to add all the order fields as event attributes part of the event we are emitting.
| return sdk.NewEvent(TypeEvtCloseSpotOrder, | ||
| sdk.NewAttribute("order_type", order.PerpetualOrderType.String()), | ||
| sdk.NewAttribute("owner_address", order.OwnerAddress), | ||
| sdk.NewAttribute("id", strconv.FormatInt(int64(order.OrderId), 10)), |
There was a problem hiding this comment.
@cryptokage1996 we need to add all the order fields as event attributes part of the event we are emitting.
cosmic-vagabond
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://elys.atlassian.net/browse/DEV-2015